Moodle
  1. Moodle
  2. MDL-22549 Assignment important issues
  3. MDL-22611

a range of GUI breaking issues when admin grading assignments one at a time in popup.

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Assignment (2.2)
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      35980

      Description

      In "view xx submitted assignments", as admin, click on "grade" link:

      • one popup is opened.
      • introduce one grade and one comment.
      • PROBLEM C: It's impossible to add images in the comments editor.
      • PROBLEM D: The comments field has not its corresponding "submissioncommentformat" field.
      • Save changes
      • PROBLEM E: The popup remains with "horrible" page with blocks and message "Changes saved. This window should close automatically. If not, please close it now"
      • Close the popup manually. Reload the "view xx submitted assignments" pages. Both the comment and the grade have been saved properly.
      • PROBLEM F: The comment in that page shows plain text so you can see the HTML (if quick grading is enabled).
      1. 20100624-MDL-22611.patch
        33 kB
        Aparup Banerjee
      2. 20100628-MDL-22611.patch
        32 kB
        Aparup Banerjee
      3. mdl-22611.patch
        32 kB
        Aparup Banerjee
      4. mdl-22611-1.patch
        32 kB
        Aparup Banerjee

        Activity

        Hide
        Aparup Banerjee added a comment -

        so apparently this area's missing file picker access is due to a missing itemid.. that the tinyMCE plugin knows about and thus doesn't show the image button. Dongsheng suggested upgrading this area to use moodle forms.. will look into that..

        Show
        Aparup Banerjee added a comment - so apparently this area's missing file picker access is due to a missing itemid.. that the tinyMCE plugin knows about and thus doesn't show the image button. Dongsheng suggested upgrading this area to use moodle forms.. will look into that..
        Hide
        Aparup Banerjee added a comment -

        i've created a patch for a few changes to this area. It addresses the issues described in the bug.

        • Also the patch changes the popup type grading to a main window based navigation.
        • PROBLEM F: was not fixed. there is a problem with showing plain text in quick grading -> saving causes the displayed(non-html) text to overwrite the original html data.

        note: PROBLEM D was dealt with by field mapping in the code to suit the Files API requirements. ( instead of changing the db field i suppose)

        Show
        Aparup Banerjee added a comment - i've created a patch for a few changes to this area. It addresses the issues described in the bug. Also the patch changes the popup type grading to a main window based navigation. PROBLEM F: was not fixed. there is a problem with showing plain text in quick grading -> saving causes the displayed(non-html) text to overwrite the original html data. note: PROBLEM D was dealt with by field mapping in the code to suit the Files API requirements. ( instead of changing the db field i suppose)
        Hide
        Aparup Banerjee added a comment -

        patch created that addresses issues -> for HEAD.

        Show
        Aparup Banerjee added a comment - patch created that addresses issues -> for HEAD.
        Hide
        Martin Dougiamas added a comment -

        OK, some quick feedback from looking at the diff.

        1) Don't use $_POST at all. Use $mform->is_cancelled and inspect $fromform->buttonname instead.

        2) Don't use <p> unless it really is a paragraph of text. In this case the help images don't really need a container anyway.

        Show
        Martin Dougiamas added a comment - OK, some quick feedback from looking at the diff. 1) Don't use $_POST at all. Use $mform->is_cancelled and inspect $fromform->buttonname instead. 2) Don't use <p> unless it really is a paragraph of text. In this case the help images don't really need a container anyway.
        Hide
        Aparup Banerjee added a comment -

        amended patch based on feedback.

        Show
        Aparup Banerjee added a comment - amended patch based on feedback.
        Hide
        Aparup Banerjee added a comment -

        note: i couldn't use '$fromform->buttonname' as instantiation of mform is in various (type)/assignments.class.php whereas mod/assignment/lib.php is where checking of buttons was needed.
        so instead of a rewrite of the code structure of this area - i went with if(optional_param( 'button_mode_name' , PARAM_BOOL )

        { $mode='...'}

        ..

        Show
        Aparup Banerjee added a comment - note: i couldn't use '$fromform->buttonname' as instantiation of mform is in various (type)/assignments.class.php whereas mod/assignment/lib.php is where checking of buttons was needed. so instead of a rewrite of the code structure of this area - i went with if(optional_param( 'button_mode_name' , PARAM_BOOL ) { $mode='...'} ..
        Hide
        Aparup Banerjee added a comment -

        updated patch based on QA meeting with M.

        Show
        Aparup Banerjee added a comment - updated patch based on QA meeting with M.
        Hide
        Aparup Banerjee added a comment -

        shortened title of single submission grading display page. going to commit this patch to HEAD.

        Show
        Aparup Banerjee added a comment - shortened title of single submission grading display page. going to commit this patch to HEAD.
        Hide
        Aparup Banerjee added a comment -

        committed to HEAD. patch addresses MDL-22608 too.

        Show
        Aparup Banerjee added a comment - committed to HEAD. patch addresses MDL-22608 too.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: