Moodle
  1. Moodle
  2. MDL-22676

AMOS edit string box shrinks to a non usable size in FF

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.1
    • Component/s: Language
    • Labels:
      None
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      490

      Description

      When attempting to edit a large string, in FF 3.5 the edit box shrinks to a small size, thus making editing really difficult.

      For example, try to edit "bloglevelupgradedescription" string in admin section. The edit box allow only to see three lines.

      1. MDL-22676_patch.txt
        2 kB
        Ray Guo
      1. screenshot 1024by768.png
        32 kB
      2. screenshot 1024by768.png
        32 kB
      3. screenshot 1280by1024.png
        34 kB
      4. screenshot 800by600.png
        28 kB

        Activity

        Hide
        Ray Guo added a comment -

        At the moment all the 'Local customization' textarea box has been set to a fixed length (4em) which only shows 3 rows no matter how long the text in the 'Standard text' column is.

        My suggesting fix is to increase the length of the textarea box if the lenght of the standard text is over 200 characters including the white space.
        For example, if the standard text is 410 character, the textarea box will be set to 8em (2 times standard length).

        If the standard text is 710 character, the textarea box will be set to 12em (3 times standard length).

        If thestandard text is 50 characters (less than 200 characters), it will use the default lenght 4em.

        I have tested it in various resultions such as 800X600, 1024x768 and 1280X1024 and they all looks reasonable well.

        I have attached 3 screen shots taken in the above resultions.

        By the way, I also fixed the validating errors of this page by adding the cols and rows attributes to the textarea box.

        The patch for the fix code is also attached.

        Show
        Ray Guo added a comment - At the moment all the 'Local customization' textarea box has been set to a fixed length (4em) which only shows 3 rows no matter how long the text in the 'Standard text' column is. My suggesting fix is to increase the length of the textarea box if the lenght of the standard text is over 200 characters including the white space. For example, if the standard text is 410 character, the textarea box will be set to 8em (2 times standard length). If the standard text is 710 character, the textarea box will be set to 12em (3 times standard length). If thestandard text is 50 characters (less than 200 characters), it will use the default lenght 4em. I have tested it in various resultions such as 800X600, 1024x768 and 1280X1024 and they all looks reasonable well. I have attached 3 screen shots taken in the above resultions. By the way, I also fixed the validating errors of this page by adding the cols and rows attributes to the textarea box. The patch for the fix code is also attached.
        Hide
        Ray Guo added a comment -

        The screen shots and the patch.

        Show
        Ray Guo added a comment - The screen shots and the patch.
        Hide
        Ray Guo added a comment -

        Screenshot taken in 800 by 600

        Show
        Ray Guo added a comment - Screenshot taken in 800 by 600
        Hide
        David Mudrak added a comment -

        Yup, I like it. Thanks!

        Show
        David Mudrak added a comment - Yup, I like it. Thanks!
        Hide
        David Mudrak added a comment -

        I just committed a patch that combines Ray's solution (computed min-height) with the solution used in AMOS at lang.moodle.org. All textarea's are enlarged by Javascript so that they take all the available space in their table cell.

        Thanks for the report and for the suggested fix.

        Show
        David Mudrak added a comment - I just committed a patch that combines Ray's solution (computed min-height) with the solution used in AMOS at lang.moodle.org. All textarea's are enlarged by Javascript so that they take all the available space in their table cell. Thanks for the report and for the suggested fix.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: