Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22678

Notices and popups in glossary

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Glossary, Usability
    • Labels:
      None

      Description

      While fixing some typos in some queries in the glossary, these have been detected:

      1) Notice: Undefined property: stdClass::$rating in C:\xampp\xampp\htdocs\moodle\moodle\mod\glossary\lib.php on line 1097. Not sure how this has changed from 1.9 ratings, please review if that must be filled with anything or, simply, one empty() check is enough.

      2) Glossary entries aren't showed in popups anymore, but the close button remains. Should be enforce popus for them (yes I know the XHTML thing, but there are ways in JS) or should we delete the button forever. Plz, discuss this with MD.

      Ciao

        Attachments

        1. 20100608_glossary.patch
          4 kB
          Andrew Davis
        2. screenshot-1.jpg
          84 kB
          Joseph Rézeau

          Issue Links

            Activity

              People

              Assignee:
              andyjdavis Andrew Davis
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Tester:
              Nobody
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Barbara Ramiro, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10