Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22680

setnew_password_and_mail in Moodlelib updates the database without using salt

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.8, 1.9
    • Fix Version/s: 1.8.13, 1.9.9, 2.0
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      It does set_field('user', 'password', md5($newpassword), 'id', $user->id)

      I found this in passing while grepping for newpassword.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            skodak Petr Skoda added a comment -

            fixed, big thanks for the report!!

            Show
            skodak Petr Skoda added a comment - fixed, big thanks for the report!!

              People

              • Assignee:
                skodak Petr Skoda
                Reporter:
                timhunt Tim Hunt
                Tester:
                Nobody
                Participants:
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Jun/10