Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22740

courses I have taught is broken for 1.9

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.9
    • Fix Version/s: 1.9.10
    • Component/s: Backup, Course
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      The patch provided by MDL-19880 produces a regression error on Moodle 1.9. The code there passes '' as the parameter for $fields so you get a query that looks like "SELECT FROM mdl_course WHERE id IN (..."

      The solution should be to change line 32 in course/import/activities/mod.php to

      $taught_courses = get_records_list('course', 'id', $tcourseids, 'sortorder', 'id, fullname');

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Fixed, thanks Alan!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Fixed, thanks Alan!
            Hide
            dougiamas Martin Dougiamas added a comment - - edited

            Gah, bummer. Thanks, Alan and Eloy!

            Show
            dougiamas Martin Dougiamas added a comment - - edited Gah, bummer. Thanks, Alan and Eloy!
            Hide
            alextdel Alex Delaforce added a comment -

            Hi, I have this problem and have downloaded the latest version as at 15 June, the file still has a missing or empty parameter as above. We cleared our cache in case our download was not the latest but the file is still broken.
            We have fixed this manually using the above suggestion.
            Main download source needs updating.

            Show
            alextdel Alex Delaforce added a comment - Hi, I have this problem and have downloaded the latest version as at 15 June, the file still has a missing or empty parameter as above. We cleared our cache in case our download was not the latest but the file is still broken. We have fixed this manually using the above suggestion. Main download source needs updating.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Strange, I've double-checked it and version 1.9.2.5 (1st line in the file), has the change applied:

            http://cvs.moodle.org/moodle/course/import/activities/mod.php?r1=1.9.2.4&r2=1.9.2.5

            Perhaps you are running latest weekly version ? Then you need to wait until new weekly arrives (24h from now).

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Strange, I've double-checked it and version 1.9.2.5 (1st line in the file), has the change applied: http://cvs.moodle.org/moodle/course/import/activities/mod.php?r1=1.9.2.4&r2=1.9.2.5 Perhaps you are running latest weekly version ? Then you need to wait until new weekly arrives (24h from now). Ciao

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Oct/10