Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.9
    • Fix Version/s: 1.9.10
    • Component/s: SCORM
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Running into a potential bug - it appears that the scorm module does backup data from the scorm_scoes_data table but is missing the code to restore that backed up information. Is this intentional or a bug? If intentional, explanation as to why would be very helpful.

        Gliffy Diagrams

        1. scorm_restorelib_php.diff
          2 kB
          Michael Avelar
        2. scorm_restorelib_php.diff
          2 kB
          Michael Avelar

          Activity

          Hide
          Mark Nielsen added a comment -

          Asked this question in the dev chat, Eloy responded with these comments:

          it sounds to me I commented something like that with Dan and some of the tables were related with SCORM 2004 sequencing, that aren't in use yet. But scoes_data isn't part of them, if 'm not wrong.

          And...

          (I think that the scorm_scoes_data contains package information... and seems to be filled when the package is deployed, thing that would happen after restore the 1st time module is "used" ?)

          We did try restoring the scorm and then attempting it and it didn't seem to populate the scorm_scoes_data table. Perhaps more testing is needed here?

          Show
          Mark Nielsen added a comment - Asked this question in the dev chat, Eloy responded with these comments: it sounds to me I commented something like that with Dan and some of the tables were related with SCORM 2004 sequencing, that aren't in use yet. But scoes_data isn't part of them, if 'm not wrong. And... (I think that the scorm_scoes_data contains package information... and seems to be filled when the package is deployed, thing that would happen after restore the 1st time module is "used" ?) We did try restoring the scorm and then attempting it and it didn't seem to populate the scorm_scoes_data table. Perhaps more testing is needed here?
          Hide
          Dan Marsden added a comment -

          Hi Mark,

          looking back at the history of scorm_scoes_data it looks like Bobo added the table in Nov 2006, included backup code, but didn't do the restore code at the same time - I would assume that this is just a bug and not done intentionally. - interesting that no-one has noticed it till now!

          feel free to attach a patch to fix - otherwise I'll try to get to it at some point in future!

          thanks!

          Show
          Dan Marsden added a comment - Hi Mark, looking back at the history of scorm_scoes_data it looks like Bobo added the table in Nov 2006, included backup code, but didn't do the restore code at the same time - I would assume that this is just a bug and not done intentionally. - interesting that no-one has noticed it till now! feel free to attach a patch to fix - otherwise I'll try to get to it at some point in future! thanks!
          Hide
          Michael Blake added a comment -

          Hi Dan, are you able to commit some time to resolving this one? Mark has indicated that this is a priority for Moodlerooms.

          Show
          Michael Blake added a comment - Hi Dan, are you able to commit some time to resolving this one? Mark has indicated that this is a priority for Moodlerooms.
          Hide
          Michael Avelar added a comment -

          Here is a patch file for 1.9.9+ for:

          • /mod/scorm/restorelib.php

          This adds a function to restore scorm_scoes associated scorm_scoes_data information.

          Show
          Michael Avelar added a comment - Here is a patch file for 1.9.9+ for: /mod/scorm/restorelib.php This adds a function to restore scorm_scoes associated scorm_scoes_data information.
          Show
          Michael Avelar added a comment - These tracker issues may be related: MDL-21299: cmi.core.lesson_location incorrectly set upon exiting second attempt resulting in improper initilization on entry to third attempt http://tracker.moodle.org/browse/MDL-21306 http://tracker.moodle.org/browse/MDL-21305
          Hide
          Michael Avelar added a comment -

          Slight modification to the conditional restore clause.

          Show
          Michael Avelar added a comment - Slight modification to the conditional restore clause.
          Hide
          Dan Marsden added a comment -

          Hi Michael, thanks for the patch!

          I'm reluctant to commit this before Eloys new restore code lands in HEAD - I don't want to cause any unnecessary conflicts with his incoming work. As soon as his changes go in, I'll make sure we rework this to work with the 2.0 restore and will push it in.

          thanks,

          Show
          Dan Marsden added a comment - Hi Michael, thanks for the patch! I'm reluctant to commit this before Eloys new restore code lands in HEAD - I don't want to cause any unnecessary conflicts with his incoming work. As soon as his changes go in, I'll make sure we rework this to work with the 2.0 restore and will push it in. thanks,
          Hide
          Dan Marsden added a comment -

          caught up with Eloy today and he was happy for this to go in now rather than waiting for his upcoming changes in HEAD - thanks for the report Mark and for the patch Michael! - could you please QA the commit and post results here?

          thanks,

          Show
          Dan Marsden added a comment - caught up with Eloy today and he was happy for this to go in now rather than waiting for his upcoming changes in HEAD - thanks for the report Mark and for the patch Michael! - could you please QA the commit and post results here? thanks,

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: