Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 2.0
    • Component/s: Enrolments
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      15454

      Description

      Originally the course info block contained icons and "manager" with coursemanage role.

      Steps:
      1/ rename coursemanager to coursecontact role to make sure it is not being mistaken for the new manager archetype
      2/ readd some icons for each enabled enrol plugin, not sure how to deal with cost there

      Maybe we could have basic (fast for category view) and full info for one course details view.

      1. 201009010_MDL-22795_2.0.patch
        3 kB
        Rossiani Wijaya
      2. 20100917_MDL-22795_2.0.patch
        4 kB
        Rossiani Wijaya
      1. guestwithoutpassword.gif
        0.1 kB
      2. guestwithpassword.gif
        0.3 kB
      3. paidcourseaccess.gif
        0.4 kB
      4. selfenrolwithkey.gif
        0.5 kB
      5. selfenrolwithkey.gif
        0.6 kB
      6. selfenrolwithoutkey.gif
        0.6 kB

        Activity

        Hide
        Petr Škoda added a comment -

        I am no icon artist, reassigning...

        Show
        Petr Škoda added a comment - I am no icon artist, reassigning...
        Hide
        Petr Škoda added a comment -

        Nobody wants this, going to work on it myself then...

        Show
        Petr Škoda added a comment - Nobody wants this, going to work on it myself then...
        Hide
        Petr Škoda added a comment -

        The basic support is in CVS, I have to create some new icons now.

        Show
        Petr Škoda added a comment - The basic support is in CVS, I have to create some new icons now.
        Hide
        Martin Dougiamas added a comment -

        Can you describe in more detail what the icons should mean?

        Show
        Martin Dougiamas added a comment - Can you describe in more detail what the icons should mean?
        Hide
        Petr Škoda added a comment -

        I suppose we need icons only for plugins that allow some kind of "self enrolment"

        enrol/guest:

        • guest access with password
          * guest access without password

        enrol/self

        • self enrolment with key
        • self enrolment without key

        enrol/paypal
        * paid course access

        These icons should be stored in pix subdirectory in these plugins

        Show
        Petr Škoda added a comment - I suppose we need icons only for plugins that allow some kind of "self enrolment" enrol/guest: guest access with password * guest access without password enrol/self self enrolment with key self enrolment without key enrol/paypal * paid course access These icons should be stored in pix subdirectory in these plugins
        Hide
        Martin Dougiamas added a comment -

        Do we have doors and keys in http://tango.freedesktop.org/Tango_Icon_Library ?

        Show
        Martin Dougiamas added a comment - Do we have doors and keys in http://tango.freedesktop.org/Tango_Icon_Library ?
        Hide
        Rossiani Wijaya added a comment -

        Hi Petr,

        I created the new icons as you requested. Please take a look and let me know if you want it differently.

        Rosie

        Show
        Rossiani Wijaya added a comment - Hi Petr, I created the new icons as you requested. Please take a look and let me know if you want it differently. Rosie
        Hide
        Rossiani Wijaya added a comment -

        Attached patch to display the enrolment icons.

        Create 'pix' directory for the following plugins for the above icons:

        • /enrol/guest/pix/guest.gif
        • /enrol/guest/pix/guestwithpassword.gif
        • /enrol/self/pix/self.gif
        • /enrol/self/pix/selfwithkey.gif
        • /enrol/paypal/pix/payaccess.gif

        Please let me know if it needs any changes.

        Rosie

        Show
        Rossiani Wijaya added a comment - Attached patch to display the enrolment icons. Create 'pix' directory for the following plugins for the above icons: /enrol/guest/pix/guest.gif /enrol/guest/pix/guestwithpassword.gif /enrol/self/pix/self.gif /enrol/self/pix/selfwithkey.gif /enrol/paypal/pix/payaccess.gif Please let me know if it needs any changes. Rosie
        Hide
        Martin Dougiamas added a comment -

        Petr can you check this out?

        Show
        Martin Dougiamas added a comment - Petr can you check this out?
        Hide
        Martin Dougiamas added a comment -

        selfenrolwithkey.gif could be just a key by itself.

        Show
        Martin Dougiamas added a comment - selfenrolwithkey.gif could be just a key by itself.
        Hide
        Rossiani Wijaya added a comment -

        Attach new 'selfenrolwithkey" icon.

        Show
        Rossiani Wijaya added a comment - Attach new 'selfenrolwithkey" icon.
        Hide
        Petr Škoda added a comment -

        ok, I will patch the code to use these icons

        Show
        Petr Škoda added a comment - ok, I will patch the code to use these icons
        Hide
        Martin Dougiamas added a comment -

        Can you finish this, Petr? Or should Rosie do it?

        Show
        Martin Dougiamas added a comment - Can you finish this, Petr? Or should Rosie do it?
        Hide
        Petr Škoda added a comment - - edited

        Ok, so the icons are in CVS, the plugins are returning them, now we need to make sure they are printed where necessary, thi list of places is:
        1/ frontpage - list of courses for not logged in user and admin
        2/ frontpage - combo list for not logged in user and admin
        3/ course category view (course/category.php) - for all users

        I suppose it does not make much sense to print these icons next to "My courses" list.

        The actual code that gives you the icons is

        if ($icons = enrol_get_course_info_icons($acourse)) {
          foreach ($icons as $pix_icon) {
             echo $OUTPUT->render($pix_icon);
          }
        }
        

        It should be in some places already, but the CSS is probably incorrect there and I might have misplaced the code a bit too...

        Show
        Petr Škoda added a comment - - edited Ok, so the icons are in CVS, the plugins are returning them, now we need to make sure they are printed where necessary, thi list of places is: 1/ frontpage - list of courses for not logged in user and admin 2/ frontpage - combo list for not logged in user and admin 3/ course category view (course/category.php) - for all users I suppose it does not make much sense to print these icons next to "My courses" list. The actual code that gives you the icons is if ($icons = enrol_get_course_info_icons($acourse)) { foreach ($icons as $pix_icon) { echo $OUTPUT->render($pix_icon); } } It should be in some places already, but the CSS is probably incorrect there and I might have misplaced the code a bit too...
        Hide
        Petr Škoda added a comment -

        Sam: could you please review patches and send to cvs if I am not online? It would be nice to get these fixes in RC, ciao and thanks everybody.

        Show
        Petr Škoda added a comment - Sam: could you please review patches and send to cvs if I am not online? It would be nice to get these fixes in RC, ciao and thanks everybody.
        Hide
        Rossiani Wijaya added a comment -

        Update patch, as suggested by Petr.

        Hi Petr/Sam,
        The only icon that hasn't been set is 'paid course icon'. I'm not too sure how to set a paid course in icon. Could you provide some info regarding this course? Once I understand how it works, I could implement the patch for the paid course.

        Thanks.
        Rosie

        Show
        Rossiani Wijaya added a comment - Update patch, as suggested by Petr. Hi Petr/Sam, The only icon that hasn't been set is 'paid course icon'. I'm not too sure how to set a paid course in icon. Could you provide some info regarding this course? Once I understand how it works, I could implement the patch for the paid course. Thanks. Rosie
        Hide
        Petr Škoda added a comment -

        paid course is mostly paypal, we might just use paypal icon
        each payment plugin might use different icon - or we might just use one icon in course lists and service specific icons on the enrolment page...

        Show
        Petr Škoda added a comment - paid course is mostly paypal, we might just use paypal icon each payment plugin might use different icon - or we might just use one icon in course lists and service specific icons on the enrolment page...
        Hide
        Sam Hemelryk added a comment -

        Hi guys,

        Looks like you two were working on the same thing at the same time, Rosie's patch is doing what Petr's commits are doing.

        I've just commit a patch that adds the icons for the available courses (agree my courses makes no sense).
        Having read this issue it looks at though everything is done as described, I'll leave it open presently but perhaps Petr/Rosie you could double check everything has been done.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi guys, Looks like you two were working on the same thing at the same time, Rosie's patch is doing what Petr's commits are doing. I've just commit a patch that adds the icons for the available courses (agree my courses makes no sense). Having read this issue it looks at though everything is done as described, I'll leave it open presently but perhaps Petr/Rosie you could double check everything has been done. Cheers Sam
        Hide
        Rossiani Wijaya added a comment -

        All necessary code fix and icons has been added since pre-release of 2.0.

        Tested and it works.

        Thanks everyone

        Rosie

        resolved.

        Show
        Rossiani Wijaya added a comment - All necessary code fix and icons has been added since pre-release of 2.0. Tested and it works. Thanks everyone Rosie resolved.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: