Moodle
  1. Moodle
  2. MDL-21782 Major 2.0 enrolments rewrite META
  3. MDL-22797

Review course completion compatibility with new enrol internals

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 2.0
    • Component/s: Enrolments
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      33655

      Description

      I have seen some new enrol period and course duration things in course completion code, it needs to be reviewed and tested properly...

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          we need to replace ra.timestart, timeend with new enrol equivalents from user_enrolments table

          Show
          Petr Škoda added a comment - we need to replace ra.timestart, timeend with new enrol equivalents from user_enrolments table
          Hide
          Martin Dougiamas added a comment -

          Aaron, are you able to add this... ? You'll know both parts of this code.

          Show
          Martin Dougiamas added a comment - Aaron, are you able to add this... ? You'll know both parts of this code.
          Hide
          Aaron Barnes added a comment -

          Doh! Was using timeenrolled rather than timecreated

          Show
          Aaron Barnes added a comment - Doh! Was using timeenrolled rather than timecreated

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: