added a comment - - edited
Thanks for getting this integrated.
Whitespace issues: tabs instead of spaces and inconsistent spacing.
Apologies if I had the wrong setting of 2 instead of 4 spaces as I only read the Moodle doc development spec recently. Until you mentioned this a couple of weeks ago I had no idea of the rules set for coders!
Perhaps we should all go to Moodle school for some lessons! LOL
Ok joking apart.
Missing phpdoc's on the render_navigation_node method in renderers.php
What are theses?
config.php layouts using the embedded.php don't have options.
Because I usually start off a theme using Base as a parent, I use the base config.php of which this section is included...
// Embeded pages, like iframe/object embeded in moodleform - it needs as much space as possible
'embedded' => array(
'file' => 'embedded.php',
'regions' => array(),
'options' => array('nofooter'=>true, 'nonavbar'=>true, 'nocustommenu'=>true),
Has this been changed since Moodle 2.0.3 (Build: 20110505)?
Changed footer removing powered by text.
Ahhh! I thought that was a cool bit of text! You obviously didn't get the meaning. I think of Afterburner as a spaceship powered by Moodle. Hence my reference, in an earlier comment here, about it being on the wrong launchpad!
Ah well you can't win em all!
I am happy the theme got accepted.
Thanks for all your help Sam...I think I'm getting there slowly...so much to learn.