Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      Moodle 2
    • Rank:
      2606

      Issue Links

        Activity

        Hide
        Mary Evans added a comment -

        Starting development

        Show
        Mary Evans added a comment - Starting development
        Hide
        Mary Evans added a comment -

        Reopened

        Show
        Mary Evans added a comment - Reopened
        Hide
        Mary Evans added a comment -

        Hopefully all past errors have been fixed.
        Afterburner is now on route for final COUNTDOWN...

        Show
        Mary Evans added a comment - Hopefully all past errors have been fixed. Afterburner is now on route for final COUNTDOWN...
        Hide
        Mary Evans added a comment -

        Well I don't have a clue what's happening to this now. I could only set it up for Peer Review at the beginning of May. Today I decided to come see how it's progressing and find nothing doing.

        Is Afterburner on the wrong 'Launch Pad' LOL

        I don't understand it. The option under work-flow is different than it was when I came to reopen this. The option then was to submit for Peer Review, which was the only option at that time, but now I find I can submit it for Integration Review. Is that a posh word for Pull Request?

        Ciao
        Mary

        Show
        Mary Evans added a comment - Well I don't have a clue what's happening to this now. I could only set it up for Peer Review at the beginning of May. Today I decided to come see how it's progressing and find nothing doing. Is Afterburner on the wrong 'Launch Pad' LOL I don't understand it. The option under work-flow is different than it was when I came to reopen this. The option then was to submit for Peer Review, which was the only option at that time, but now I find I can submit it for Integration Review. Is that a posh word for Pull Request? Ciao Mary
        Hide
        Sam Hemelryk added a comment -

        Hi Mary,

        This has been integrated now.
        I made the following changes during integration:

        • Whitespace issues: tabs instead of spaces and inconsistent spacing.
        • Missing phpdoc's on the render_navigation_node method in renderers.php
        • config.php layouts using the embedded.php don't have options.
        • Changed footer removing powered by text.

        I will also create a couple of small bugs to see a couple of other changes however at this point I think it is ready to go in - so in it goes

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi Mary, This has been integrated now. I made the following changes during integration: Whitespace issues: tabs instead of spaces and inconsistent spacing. Missing phpdoc's on the render_navigation_node method in renderers.php config.php layouts using the embedded.php don't have options. Changed footer removing powered by text. I will also create a couple of small bugs to see a couple of other changes however at this point I think it is ready to go in - so in it goes Cheers Sam
        Hide
        Sam Hemelryk added a comment -

        Added more specific test instructions.

        Show
        Sam Hemelryk added a comment - Added more specific test instructions.
        Hide
        Mary Evans added a comment - - edited

        Hi Sam,

        Thanks for getting this integrated.

        Whitespace issues: tabs instead of spaces and inconsistent spacing.

        Apologies if I had the wrong setting of 2 instead of 4 spaces as I only read the Moodle doc development spec recently. Until you mentioned this a couple of weeks ago I had no idea of the rules set for coders!

        Perhaps we should all go to Moodle school for some lessons! LOL

        Ok joking apart.

        Missing phpdoc's on the render_navigation_node method in renderers.php

        What are theses?

        config.php layouts using the embedded.php don't have options.

        Because I usually start off a theme using Base as a parent, I use the base config.php of which this section is included...

        // Embeded pages, like iframe/object embeded in moodleform - it needs as much space as possible
        'embedded' => array(
        'file' => 'embedded.php',
        'regions' => array(),
        'options' => array('nofooter'=>true, 'nonavbar'=>true, 'nocustommenu'=>true),
        ),

        Has this been changed since Moodle 2.0.3 (Build: 20110505)?

        Changed footer removing powered by text.

        Ahhh! I thought that was a cool bit of text! You obviously didn't get the meaning. I think of Afterburner as a spaceship powered by Moodle. Hence my reference, in an earlier comment here, about it being on the wrong launchpad!

        Ah well you can't win em all!

        I am happy the theme got accepted.

        Thanks for all your help Sam...I think I'm getting there slowly...so much to learn.

        Ciao
        Mary

        Show
        Mary Evans added a comment - - edited Hi Sam, Thanks for getting this integrated. Whitespace issues: tabs instead of spaces and inconsistent spacing. Apologies if I had the wrong setting of 2 instead of 4 spaces as I only read the Moodle doc development spec recently. Until you mentioned this a couple of weeks ago I had no idea of the rules set for coders! Perhaps we should all go to Moodle school for some lessons! LOL Ok joking apart. Missing phpdoc's on the render_navigation_node method in renderers.php What are theses? config.php layouts using the embedded.php don't have options. Because I usually start off a theme using Base as a parent, I use the base config.php of which this section is included... // Embeded pages, like iframe/object embeded in moodleform - it needs as much space as possible 'embedded' => array( 'file' => 'embedded.php', 'regions' => array(), 'options' => array('nofooter'=>true, 'nonavbar'=>true, 'nocustommenu'=>true), ), Has this been changed since Moodle 2.0.3 (Build: 20110505)? Changed footer removing powered by text. Ahhh! I thought that was a cool bit of text! You obviously didn't get the meaning. I think of Afterburner as a spaceship powered by Moodle. Hence my reference, in an earlier comment here, about it being on the wrong launchpad! Ah well you can't win em all! I am happy the theme got accepted. Thanks for all your help Sam...I think I'm getting there slowly...so much to learn. Ciao Mary
        Hide
        Martin Dougiamas added a comment -

        Hi Mary,

        See http://docs.moodle.org/en/Development:Process (especially the diagram). Should help!

        Show
        Martin Dougiamas added a comment - Hi Mary, See http://docs.moodle.org/en/Development:Process (especially the diagram). Should help!
        Hide
        Aparup Banerjee added a comment -

        this looks fantastic on chrome for me. just running a quick test on the other browsers now.

        Show
        Aparup Banerjee added a comment - this looks fantastic on chrome for me. just running a quick test on the other browsers now.
        Hide
        Aparup Banerjee added a comment - - edited

        This works great!
        tested on safari 5.0.5, ie8 (vv slight custom menu arrow shading difference), ff3.6 and chromium(chrome) 10.

        really like the theme too!

        Show
        Aparup Banerjee added a comment - - edited This works great! tested on safari 5.0.5, ie8 (vv slight custom menu arrow shading difference), ff3.6 and chromium(chrome) 10. really like the theme too!
        Hide
        Mary Evans added a comment -

        @Martin
        Thanks Martin, I have read that and found it really useful! Thanks

        @Aparup
        Thanks for testing Afterburner, glad you like the theme and that it performed well in all those browsers! You made my day!

        Cheers
        Mary

        Show
        Mary Evans added a comment - @Martin Thanks Martin, I have read that and found it really useful! Thanks @Aparup Thanks for testing Afterburner, glad you like the theme and that it performed well in all those browsers! You made my day! Cheers Mary
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And this is now part of Moodle upstream, many thanks!

        PS: I'm editing the title of the issue as far as the theme has been added to "master" only, afaik.

        Show
        Eloy Lafuente (stronk7) added a comment - And this is now part of Moodle upstream, many thanks! PS: I'm editing the title of the issue as far as the theme has been added to "master" only, afaik.
        Hide
        Mary Evans added a comment -

        Thanks Eloy!

        Show
        Mary Evans added a comment - Thanks Eloy!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: