Moodle
  1. Moodle
  2. MDL-22874

Add 20 theme to the Moodle 2.0 core

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      Moodle 2.0
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      497

      Description

      This is a meta task for myself to keep track of all of the themes to go into the core.

        Issue Links

          Activity

          Hide
          Martin Dougiamas added a comment -

          I just fixed some core themes that had a mistakenly-named "general" layout (should be called "standard"). This was causing bugs like blocks not appearing on some pages like calendars etc

          arialist/config.php binarius/config.php boxxie/config.php canvas/config.php formfactor/config.php fusion/config.php leatherbound/config.php nonzero/config.php

          Just wanted to mention it to catch any future themes from inheriting the issue.

          Show
          Martin Dougiamas added a comment - I just fixed some core themes that had a mistakenly-named "general" layout (should be called "standard"). This was causing bugs like blocks not appearing on some pages like calendars etc arialist/config.php binarius/config.php boxxie/config.php canvas/config.php formfactor/config.php fusion/config.php leatherbound/config.php nonzero/config.php Just wanted to mention it to catch any future themes from inheriting the issue.
          Hide
          Mauno Korpelainen added a comment -

          Patrick & John,

          when you add these new themes could you please doublecheck the format of settings.php :

          defined('MOODLE_INTERNAL') || die;

          if ($ADMIN->fulltree) {

          instead of

          $temp = new admin_settingpage('theme_xxx...
          ...
          and $settings->add($setting); instead of $temp->add($setting);

          or we will get 40 themes to our theme administration menu

          From current core themes Brick, Fusion, Magazine, Overlay, Sky High and Splash are using the "old theme settings.php style" which renders double links in administration menu... like Joseph pointed in http://moodle.org/mod/forum/discuss.php?d=154251

          Show
          Mauno Korpelainen added a comment - Patrick & John, when you add these new themes could you please doublecheck the format of settings.php : defined('MOODLE_INTERNAL') || die; if ($ADMIN->fulltree) { instead of $temp = new admin_settingpage('theme_xxx... ... and $settings->add($setting); instead of $temp->add($setting); or we will get 40 themes to our theme administration menu From current core themes Brick, Fusion, Magazine, Overlay, Sky High and Splash are using the "old theme settings.php style" which renders double links in administration menu... like Joseph pointed in http://moodle.org/mod/forum/discuss.php?d=154251
          Hide
          John Stabinger added a comment -

          Thanks for the heads up Mauno. All of the themes you mentioned should now be using the updated code.

          Show
          John Stabinger added a comment - Thanks for the heads up Mauno. All of the themes you mentioned should now be using the updated code.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: