Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22970

Glossary import displays too many items in recent activity

    XMLWordPrintable

Details

    • MOODLE_19_STABLE, MOODLE_20_STABLE
    • MOODLE_19_STABLE, MOODLE_20_STABLE
    • Moderate

    Description

      (Note: This probably applies to 1.9 also but I am filing it on 2 because that's where I am testing)

      To reproduce, do the following, and BE AWARE THAT THESE STEPS MAY CRASH YOUR BROWSER.

      1) Create new disposable course
      2) Add a glossary
      3) Import the attached 1,000-entry glossary (note - although the attached example is fake, this is not an unrealistic glossary size - we have several courses using larger)
      4) Return to course page

      Assuming you don't have glossary auto-link on, the 'Recent activity' block will appear with all 1,000 glossary entries shown. This is poor behaviour. I would expect either:

      A) Recent activity shows 'Admin user / Imported 1,000 entries' instead of showing each one individually.
      or
      B) If there are more than, say, 5 new entries then the glossary falls back to just showing '968 new glossary entries'
      or
      C) If there are more than, say, 5 new entries then the glossary displays the first 5 and then '(... and more ...)' or something

      If you have glossary auto-link on, step 4 will crash your browser, presumably because it tries to actually apply the filter (which performs poorly with 1,000 entries, I will file another bug about that) a thousand times and maybe adds some javascript for each one or whatever, I don't know. However, I suspect that if a limit were placed on the number displayed, this would fix the problem anyway.

      (note: by 'crash your browser' I mean, peg its CPU at max; I left it for a minute - Firefox, IE7 - but it didn't finish.)

      Attachments

        1. course.png
          course.png
          75 kB
        2. glossary1000.xml
          371 kB

        Issue Links

          Activity

            People

              nebgor Aparup Banerjee
              quen Sam Marshall
              Jérôme Mouneyrac Jérôme Mouneyrac
              Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                21/Feb/11