Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Repositories
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      852

      Description

      This is a meta list of issues found during internal code review and MDL-22950

      Please do not commit any fixes before MDL-22950 lands, thanks!

        Activity

        Hide
        Petr Škoda added a comment -

        I am going to post more feedback about individual plugins later

        Show
        Petr Škoda added a comment - I am going to post more feedback about individual plugins later
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Hi Dongsheng,

        while reviewing files here & there I just found repository/url/locallib.php

        It seems to be 100% thirty-part lib, so I'd recommend to add it to lib/thirdpartylibs.xml to have it under control.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Hi Dongsheng, while reviewing files here & there I just found repository/url/locallib.php It seems to be 100% thirty-part lib, so I'd recommend to add it to lib/thirdpartylibs.xml to have it under control. Ciao
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d.

        TW9vZGxlDQo=

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
        Hide
        Michael de Raadt added a comment -

        I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        This is being done as part of a bulk annual clean-up of issues.

        If you still believe this is an issue in supported versions, please create a new issue.

        Show
        Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: