Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22999

Allow maximum points for graded activities to exceed 100

    Details

    • Testing Instructions:
      Hide

      TC1 – Adding a graded activity and setting the maximum grade point

      1. Steps
        1. User adds a graded activity and selects the following:
        2. Site wide grade point maximum is set to 900, grade point default is set to 800.
        3. Grade Type - 'point'
        4. Scale - disabled because Grade Type is not 'scale'
        5. Maximum points - 600
      2. Expected Result
        1. When the add activity page loads, under the "grade" section. The "grade element" should have "points" selected for type, and 800 as the default value for maximum points.
        2. The user submits the form and the value stored in the grade column of the module's table is 600.

      TC2 – Adding a graded activity and selecting a scale grade

      1. Steps
        1. User adds a graded activity and selects the following:
        2. Site wide grade point maximum is set to 900, grade point default is set to 800
        3. Grade Type = 'scale'
        4. Scale - Scale value
        5. Maximum points - automatically disabled because Grade Type is not 'point'
      2. Expected Result
        1. When the add activity page loads, under the "grade" section. The "grade element" should have "points" selected for type, and 800 as the default value for maximum points.
        2. The user submits the form and the value stored in the grade column of the module's table is a negative integer.

      TC3 – Adding a graded activity and selecting 'no grade'

      1. Steps
        1. User adds a graded activity and selects the following:
        2. Site wide grade point maximum is set to 900, grade point default is set to 800.
        3. Grade Type = 'No grade'
        4. Scale - disabled because Grade Type is not 'scale'
        5. Maximum points - disabled because Grade Type is not 'point'
      2. Expected Result
        1. When the add activity page loads, under the "grade" section. The "grade element" should have "points" selected for type, and 800 as the default value for maximum points.
        2. The user submits the form and the value stored in the grade column of the module's table is 0.

      TC4 – Adding a graded activity and setting the maximum grade point higher than the site imposed maximum

      1. Steps
        1. User adds a graded activity and selects the following:
        2. Site wide grade point maximum is set to 900, grade point default is set to 800.
        3. Grade Type = 'Point'
        4. Scale - disabled because Grade Type is not 'scale'
        5. Maximum points - 20000
      2. Expected Result
        1. When the add activity page loads, under the "grade" section. The "grade element" should have "points" selected for type, and 800 as the default value for maximum points.
        2. The user submits the form and validation code returns an error highlighting that the grade point entered is higher than the site imposed maximum.

      TC5 – Updating a graded activity and setting the maximum grade point

      1. Steps
        1. Site wide grade point maximum is set to 900
        2. User updates a graded activity that is using a maximum points value of 600
      2. Expected Results
        1. The Grade Type dropdown value is set to 'Point'
        2. The Scale dropdown is disabled
        3. The Maximum points text field is populated with 600

      TC6 – Updating a graded activity, whose grade was previously set to 'no grade'

      1. Steps
        1. Site wide grade point maximum is set to 900
        2. User updates a graded activity that is using a grade point value of 0
      2. Expected Results
        1. The Grade Type dropdown value is set to 'No grade'
        2. The Scale dropdown is disabled
        3. The Maximum points text field is disabled

      TC7 – Updating a graded activity, whose grade was previously using a scale

      1. Steps
        1. Site wide grade point maximum is set to 900
        2. User updates a graded activity that is using a scale value of -1
      2. Expected Results
        1. The Grade Type dropdown value is set to 'Scale'
        2. The Scale dropdown value is set to the '-1' entry
        3. The Maximum points text field is disabled

      TC8 – Updating a graded activity and setting a grade point maximum; then changing the site wide grade point maximum to a value lower than the value used by the activity

      1. Steps
        1. Set site wide grade point maximum to 900.
        2. Update a grade activity, and set it to point grading, with a maximum of 600. Save.
        3. Set site wide grade point maximum to 100.
        4. Edit the activity again.
      2. Expected Results
        1. The Grade Type dropdown value is set to 'Point'
        2. The Scale dropdown is disabled
        3. The Maximum points text field is populated with 600
        4. The user submits the form and validation code returns an error highlighting that the grade point entered is higher than the site imposed maximum.

      TC9 – Adding a graded activity and setting the grade point maximum. Change the site wide grade point maximum to a value lower than the value used by the activity. Perform a backup and restore of the graded activity

      1. Steps
        1. Site wide grade point maximum is set to 1000
        2. User creates a graded activity
          1. Grade Type = 'Point'
          2. Scale - disabled because Grade Type is not 'scale'
          3. Maximum points - 1000
        3. Saves the form
        4. Creates a backup of the course, activities and user data
        5. Site wide grade point maximum is set to 100
        6. User restores the backuped course with activities and user data
        7. User edits the graded activity
      2. Expected Results
        1. The Grade Type dropdown value is set to 'Point'
        2. The Scale dropdown is disabled
        3. The Grade Point text field is populated with 1000
        4. The user submits the form and validation code returns an error highlighting that the grade point entered is higher than the site imposed maximum.

      TC10 – Adding a graded activity and setting the grade point maximum. Change the grade point maximum. Perform a backup and restore of the graded activity

      1. Steps
        1. Site wide grade point maximum is set to 1000
        2. User creates a graded activity
          1. Grade Type = 'Point'
          2. Scale - disabled because Grade Type is not 'scale'
          3. Maximum points - 30
        3. Saves the form
        4. Creates a backup of the course, activities and user data
        5. Site wide grade point maximum is set to 100
        6. User restores the backuped course with activities and user data
        7. User edits the graded activity
      2. Expected Results
        1. The Grade Type dropdown value is set to 'Point'
        2. The Scale dropdown is disabled
        3. The Grade Point text field is populated with 30
        4. The user submits the form and the value stored in the grade column of the module's table is 30.

      TC11 – Adding a grade activity snd setting a scale grade. Perform a backup of the activity. Removed the sale used by the activity by removing it from the course (or site). Restore the activity

      1. Steps
        1. Site wide grade point maximum is set to 1000
        2. User creates a graded activity
          1. Grade Type = 'scale'
          2. Scale - Scale value
          3. Maximum points - automatically disabled because Grade Type is not 'point'
        3. Saves the form
        4. Creates a backup of the course, activities and user data
        5. The scale used in the graded activity is removed
        6. User restores the backuped course with activities and user data
        7. User edits the graded activity
      2. Expected Results
        1. The Grade Type dropdown value is set to 'Scale'
        2. The Scale defaults to the "standard scale value" of -1
        3. The Grade Point text field is disabled
        4. The user submits the form and the value stored in the grade column of the module's table is -1.

      TC12 – Adding an activity that uses rating.

      1. Steps
        1. Site wide grade point maximum is set to 100
        2. User adds a forum activity to a course.
        3. User expands "Ratings" section and changes "Aggregate Type" to a value other than "No Ratings"
        4. User changes scale type to "scale"
        5. User changes scale type to "point"
        6. User enters a value less than the maximum grade (ex. 80) into the Maximum points input box, and saves the activity.
      2. Expected Results
        1. When first expanding the "Ratings" section, all "Scale" inputs should be disabled (type/scale/maximum grade)
        2. After changing the "Aggregate Type" to a value other than "No Ratings", The "type" select box should be enabled, and set to "Point". The Maximum Grade input box should be enabled and set to the sitewide maximum grade setting (100)
        3. When changing scale type to "scale", the maximum grade input should become disabled, and the scale select box should be enabled.
        4. When changing scale type back to "point", the maximum grade input should become enabled, and the scale select box should be disabled.
        5. After entering the maximum grade value, and saving the activity, the activity should save successfully.

      TC13 – Updating an activity that uses ratings, whose rating scale was previously set to "point"

      1. Steps
        1. Site wide grade point maximum is set to 100
        2. User updates a forum activity that is using ratings and a maximum grade value of 90
      2. Expected Results
        1. The Scale Type select box value is set to 'Point'
        2. The Scale select box is disabled.
        3. The Maximum points text field is enabled and set to 90.

      TC14 – Updating an activity that uses ratings, whose rating scale was previously set to "scale"

      1. Steps
        1. Site wide grade point maximum is set to 100
        2. User updates a forum activity that is using ratings and a scale value of -1
      2. Expected Results
        1. The Scale Type select box value is set to 'Scale'
        2. The Scale select box value is set to the '-1' entry
        3. The Maximum points text field is disabled

      TC15 – Adding a workshop with Accumulative Grading

      1. Steps
        1. Site wide grade point maximum is set to 100
        2. User adds a workshop activity to a course. A name is set, and grading strategy is set to "accumulative grading"
        3. User clicks "save and display", then clicks "edit assessment form"
        4. Under "best possible grade / scale to use", the type is changed to "scale"
        5. Under "best possible grade / scale to use", the type is changed to "point"
        6. An integer is input into the maximum grade box, and the user clicks "save and close"
      2. Expected results
        1. When first viewing the edit assessment form page, next to "best possible grade / scale to use" a type select box, a scale select box, and a maximum grade text box is present. The type select box is set to "point", the scale select box is disabled, and the maximum grade box is set to 10
        2. When "best possible grade / scale to use" type is changed to "scale", the scale select box is enabled, and the maximum grade box is disabled.

      TC16 – Setting the maximum and default grade point values.

      1. Steps
        1. User navigates to Site Administration > Grades > General Settings
        2. User sets the maximum grade point value to 100. and clicks "Save Changes"
        3. User leaves the maximum grade point value at 100, sets the grade point default value to 101, and clicks "Save Changes"
        4. User leaves the maximum grade point value at 100, sets the grade point default value to 90, and clicks "Save Changes"
        5. User sets the maximum grade point value to 80, leaves the grade point default value at 90, and clicks "Save Changes"
        6. User sets the maximum grade point value to 90, leaves the grade point default value at 90, and clicks "Save Changes"
        7. User sets the maximum grade point value to to 85, changes the grade point default value to 80, and clicks "Save Changes"
        8. User sets the maximum grade point value to to 80, changes the grade point default value to 85, and clicks "Save Changes"
        9. User sets the maximum grade point value back to 100, the default grade point value back to 100, and clicks "Save Changes"
      2. Expected Results.
        1. After step 3, a validation error should be shown, stating that the default value cannot exceed the maximum value. The values should not have saved.
        2. After step 4, the values should save successfully.
        3. After step 5, a validation error should be shown, stating that the default value cannot exceed the maximum value. The values should not have saved.
        4. After step 6, the values should save successfully.
        5. After step 7, the values should save successfully.
        6. After step 8, a validation error should be shown, stating that the default value cannot exceed the maximum value. The values should not have saved.
        7. After step 9, the values should save successfully.
      Show
      TC1 – Adding a graded activity and setting the maximum grade point Steps User adds a graded activity and selects the following: Site wide grade point maximum is set to 900, grade point default is set to 800. Grade Type - 'point' Scale - disabled because Grade Type is not 'scale' Maximum points - 600 Expected Result When the add activity page loads, under the "grade" section. The "grade element" should have "points" selected for type, and 800 as the default value for maximum points. The user submits the form and the value stored in the grade column of the module's table is 600. TC2 – Adding a graded activity and selecting a scale grade Steps User adds a graded activity and selects the following: Site wide grade point maximum is set to 900, grade point default is set to 800 Grade Type = 'scale' Scale - Scale value Maximum points - automatically disabled because Grade Type is not 'point' Expected Result When the add activity page loads, under the "grade" section. The "grade element" should have "points" selected for type, and 800 as the default value for maximum points. The user submits the form and the value stored in the grade column of the module's table is a negative integer. TC3 – Adding a graded activity and selecting 'no grade' Steps User adds a graded activity and selects the following: Site wide grade point maximum is set to 900, grade point default is set to 800. Grade Type = 'No grade' Scale - disabled because Grade Type is not 'scale' Maximum points - disabled because Grade Type is not 'point' Expected Result When the add activity page loads, under the "grade" section. The "grade element" should have "points" selected for type, and 800 as the default value for maximum points. The user submits the form and the value stored in the grade column of the module's table is 0. TC4 – Adding a graded activity and setting the maximum grade point higher than the site imposed maximum Steps User adds a graded activity and selects the following: Site wide grade point maximum is set to 900, grade point default is set to 800. Grade Type = 'Point' Scale - disabled because Grade Type is not 'scale' Maximum points - 20000 Expected Result When the add activity page loads, under the "grade" section. The "grade element" should have "points" selected for type, and 800 as the default value for maximum points. The user submits the form and validation code returns an error highlighting that the grade point entered is higher than the site imposed maximum. TC5 – Updating a graded activity and setting the maximum grade point Steps Site wide grade point maximum is set to 900 User updates a graded activity that is using a maximum points value of 600 Expected Results The Grade Type dropdown value is set to 'Point' The Scale dropdown is disabled The Maximum points text field is populated with 600 TC6 – Updating a graded activity, whose grade was previously set to 'no grade' Steps Site wide grade point maximum is set to 900 User updates a graded activity that is using a grade point value of 0 Expected Results The Grade Type dropdown value is set to 'No grade' The Scale dropdown is disabled The Maximum points text field is disabled TC7 – Updating a graded activity, whose grade was previously using a scale Steps Site wide grade point maximum is set to 900 User updates a graded activity that is using a scale value of -1 Expected Results The Grade Type dropdown value is set to 'Scale' The Scale dropdown value is set to the '-1' entry The Maximum points text field is disabled TC8 – Updating a graded activity and setting a grade point maximum; then changing the site wide grade point maximum to a value lower than the value used by the activity Steps Set site wide grade point maximum to 900. Update a grade activity, and set it to point grading, with a maximum of 600. Save. Set site wide grade point maximum to 100. Edit the activity again. Expected Results The Grade Type dropdown value is set to 'Point' The Scale dropdown is disabled The Maximum points text field is populated with 600 The user submits the form and validation code returns an error highlighting that the grade point entered is higher than the site imposed maximum. TC9 – Adding a graded activity and setting the grade point maximum. Change the site wide grade point maximum to a value lower than the value used by the activity. Perform a backup and restore of the graded activity Steps Site wide grade point maximum is set to 1000 User creates a graded activity Grade Type = 'Point' Scale - disabled because Grade Type is not 'scale' Maximum points - 1000 Saves the form Creates a backup of the course, activities and user data Site wide grade point maximum is set to 100 User restores the backuped course with activities and user data User edits the graded activity Expected Results The Grade Type dropdown value is set to 'Point' The Scale dropdown is disabled The Grade Point text field is populated with 1000 The user submits the form and validation code returns an error highlighting that the grade point entered is higher than the site imposed maximum. TC10 – Adding a graded activity and setting the grade point maximum. Change the grade point maximum. Perform a backup and restore of the graded activity Steps Site wide grade point maximum is set to 1000 User creates a graded activity Grade Type = 'Point' Scale - disabled because Grade Type is not 'scale' Maximum points - 30 Saves the form Creates a backup of the course, activities and user data Site wide grade point maximum is set to 100 User restores the backuped course with activities and user data User edits the graded activity Expected Results The Grade Type dropdown value is set to 'Point' The Scale dropdown is disabled The Grade Point text field is populated with 30 The user submits the form and the value stored in the grade column of the module's table is 30. TC11 – Adding a grade activity snd setting a scale grade. Perform a backup of the activity. Removed the sale used by the activity by removing it from the course (or site). Restore the activity Steps Site wide grade point maximum is set to 1000 User creates a graded activity Grade Type = 'scale' Scale - Scale value Maximum points - automatically disabled because Grade Type is not 'point' Saves the form Creates a backup of the course, activities and user data The scale used in the graded activity is removed User restores the backuped course with activities and user data User edits the graded activity Expected Results The Grade Type dropdown value is set to 'Scale' The Scale defaults to the "standard scale value" of -1 The Grade Point text field is disabled The user submits the form and the value stored in the grade column of the module's table is -1. TC12 – Adding an activity that uses rating. Steps Site wide grade point maximum is set to 100 User adds a forum activity to a course. User expands "Ratings" section and changes "Aggregate Type" to a value other than "No Ratings" User changes scale type to "scale" User changes scale type to "point" User enters a value less than the maximum grade (ex. 80) into the Maximum points input box, and saves the activity. Expected Results When first expanding the "Ratings" section, all "Scale" inputs should be disabled (type/scale/maximum grade) After changing the "Aggregate Type" to a value other than "No Ratings", The "type" select box should be enabled, and set to "Point". The Maximum Grade input box should be enabled and set to the sitewide maximum grade setting (100) When changing scale type to "scale", the maximum grade input should become disabled, and the scale select box should be enabled. When changing scale type back to "point", the maximum grade input should become enabled, and the scale select box should be disabled. After entering the maximum grade value, and saving the activity, the activity should save successfully. TC13 – Updating an activity that uses ratings, whose rating scale was previously set to "point" Steps Site wide grade point maximum is set to 100 User updates a forum activity that is using ratings and a maximum grade value of 90 Expected Results The Scale Type select box value is set to 'Point' The Scale select box is disabled. The Maximum points text field is enabled and set to 90. TC14 – Updating an activity that uses ratings, whose rating scale was previously set to "scale" Steps Site wide grade point maximum is set to 100 User updates a forum activity that is using ratings and a scale value of -1 Expected Results The Scale Type select box value is set to 'Scale' The Scale select box value is set to the '-1' entry The Maximum points text field is disabled TC15 – Adding a workshop with Accumulative Grading Steps Site wide grade point maximum is set to 100 User adds a workshop activity to a course. A name is set, and grading strategy is set to "accumulative grading" User clicks "save and display", then clicks "edit assessment form" Under "best possible grade / scale to use", the type is changed to "scale" Under "best possible grade / scale to use", the type is changed to "point" An integer is input into the maximum grade box, and the user clicks "save and close" Expected results When first viewing the edit assessment form page, next to "best possible grade / scale to use" a type select box, a scale select box, and a maximum grade text box is present. The type select box is set to "point", the scale select box is disabled, and the maximum grade box is set to 10 When "best possible grade / scale to use" type is changed to "scale", the scale select box is enabled, and the maximum grade box is disabled. TC16 – Setting the maximum and default grade point values. Steps User navigates to Site Administration > Grades > General Settings User sets the maximum grade point value to 100. and clicks "Save Changes" User leaves the maximum grade point value at 100, sets the grade point default value to 101, and clicks "Save Changes" User leaves the maximum grade point value at 100, sets the grade point default value to 90, and clicks "Save Changes" User sets the maximum grade point value to 80, leaves the grade point default value at 90, and clicks "Save Changes" User sets the maximum grade point value to 90, leaves the grade point default value at 90, and clicks "Save Changes" User sets the maximum grade point value to to 85, changes the grade point default value to 80, and clicks "Save Changes" User sets the maximum grade point value to to 80, changes the grade point default value to 85, and clicks "Save Changes" User sets the maximum grade point value back to 100, the default grade point value back to 100, and clicks "Save Changes" Expected Results. After step 3, a validation error should be shown, stating that the default value cannot exceed the maximum value. The values should not have saved. After step 4, the values should save successfully. After step 5, a validation error should be shown, stating that the default value cannot exceed the maximum value. The values should not have saved. After step 6, the values should save successfully. After step 7, the values should save successfully. After step 8, a validation error should be shown, stating that the default value cannot exceed the maximum value. The values should not have saved. After step 9, the values should save successfully.
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-22999-m27

      Description

      Activities... most notably assignments have always only allowed whole numbers between 0 and 100. I don't know anyone who hasn't hacked this from the first time they've used Moodle to allow at least 250 points. Also, try to enter 95.5 as an assignment grade from the assignment grading interface. This field should not be a dropdown but a text input of any valid floating point number.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  23 Vote for this issue
                  Watchers:
                  21 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/May/14