Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23006

Missing strings on table edit in XMLDB Editor

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1.1, 2.2
    • Fix Version/s: 2.1.3
    • Labels:
    • Environment:
      PHP 5.2.11
      MySQL 5.1.37
      MAMP
    • Database:
      Any
    • Testing Instructions:
      Hide

      1. Set debugging to developer and display errors to yes at Site Administration -> Development ->Debugging
      2. From the navigation block navigate to XMLDB editor at Site Administration -> Development ->XMLDB editor
      3. Locate mod/chat/db and click the [Load] link
      4. Locate mod/chat/db and click the [Edit] link
      5. Locate the chat_messages entry under "tables" and click the [Edit] link
      6. Change the name from chat_messages to chat_messages2 and click the change link.

      Verify that the notices shown in the bug description are not displayed

      Show
      1. Set debugging to developer and display errors to yes at Site Administration -> Development ->Debugging 2. From the navigation block navigate to XMLDB editor at Site Administration -> Development ->XMLDB editor 3. Locate mod/chat/db and click the [Load] link 4. Locate mod/chat/db and click the [Edit] link 5. Locate the chat_messages entry under "tables" and click the [Edit] link 6. Change the name from chat_messages to chat_messages2 and click the change link. Verify that the notices shown in the bug description are not displayed
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      mdl-23006-xmldb-missing-strings

      Description

      The following notices appear when you try to rename a table using the XMLDB editor

      Invalid get_string() identifier: 'tablenameempty' or component 'xmldb'

      • line 5982 of /lib/moodlelib.php: call to debugging()
      • line 6536 of /lib/moodlelib.php: call to core_string_manager->get_string()
      • line 138 of /admin/xmldb/actions/XMLDBAction.class.php: call to get_string()
      • line 48 of /admin/xmldb/actions/edit_table_save/edit_table_save.class.php: call to XMLDBAction->loadStrings()
      • line 60 of /admin/xmldb/actions/XMLDBAction.class.php: call to edit_table_save->init()
      • line 67 of /admin/xmldb/actions/XMLDBAction.class.php: call to XMLDBAction->XMLDBAction()
      • line 70 of /admin/xmldb/index.php: call to XMLDBAction->__construct()

      Invalid get_string() identifier: 'incorrecttablename' or component 'xmldb'

      • line 5982 of /lib/moodlelib.php: call to debugging()
      • line 6536 of /lib/moodlelib.php: call to core_string_manager->get_string()
      • line 138 of /admin/xmldb/actions/XMLDBAction.class.php: call to get_string()
      • line 48 of /admin/xmldb/actions/edit_table_save/edit_table_save.class.php: call to XMLDBAction->loadStrings()
      • line 60 of /admin/xmldb/actions/XMLDBAction.class.php: call to edit_table_save->init()
      • line 67 of /admin/xmldb/actions/XMLDBAction.class.php: call to XMLDBAction->XMLDBAction()
      • line 70 of /admin/xmldb/index.php: call to XMLDBAction->__construct()

      Invalid get_string() identifier: 'duplicatetablename' or component 'xmldb'

      • line 5982 of /lib/moodlelib.php: call to debugging()
      • line 6536 of /lib/moodlelib.php: call to core_string_manager->get_string()
      • line 138 of /admin/xmldb/actions/XMLDBAction.class.php: call to get_string()
      • line 48 of /admin/xmldb/actions/edit_table_save/edit_table_save.class.php: call to XMLDBAction->loadStrings()
      • line 60 of /admin/xmldb/actions/XMLDBAction.class.php: call to edit_table_save->init()
      • line 67 of /admin/xmldb/actions/XMLDBAction.class.php: call to XMLDBAction->XMLDBAction()
      • line 70 of /admin/xmldb/index.php: call to XMLDBAction->__construct()

        Gliffy Diagrams

          Issue Links

            Activity

            sbourget Stephen Bourget created issue -
            sbourget Stephen Bourget made changes -
            Field Original Value New Value
            Assignee Koen Roggemans [ koen ] Eloy Lafuente (stronk7) [ stronk7 ]
            Component/s Database SQL/XMLDB [ 10131 ]
            dougiamas Martin Dougiamas made changes -
            Workflow jira [ 37041 ] MDL Workflow [ 46412 ]
            dougiamas Martin Dougiamas made changes -
            Workflow MDL Workflow [ 46412 ] MDL Full Workflow [ 74687 ]
            sbourget Stephen Bourget made changes -
            Pull Master Diff URL https://github.com/sbourget/moodle/compare/MOODLE_21_STABLE...mdl-29564-mdl-23006-xmldb-missing-strings
            Pull Master Branch mdl-23006-xmldb-missing-strings
            Testing Instructions 1. Set debugging to developer and display errors to yes at Site Administration -> Development ->Debugging
            2. From the navigation block navigate to XMLDB editor at Site Administration -> Development ->XMLDB editor
            3. Locate mod/chat/db and click the [Load] link
            4. Locate mod/chat/db and click the [Edit] link
            5. Locate the chat_messages entry under "tables" and click the [Edit] link
            6. Change the name from chat_messages to chat_messages2 and click the change link.

            Verify that the notices shown in the bug description are not displayed
            Description The following notices apper when you try to rename a table using the XMLDB editor

            Invalid get_string() identifier: 'tablenameempty' or component 'xmldb'

                * line 5982 of /lib/moodlelib.php: call to debugging()
                * line 6536 of /lib/moodlelib.php: call to core_string_manager->get_string()
                * line 138 of /admin/xmldb/actions/XMLDBAction.class.php: call to get_string()
                * line 48 of /admin/xmldb/actions/edit_table_save/edit_table_save.class.php: call to XMLDBAction->loadStrings()
                * line 60 of /admin/xmldb/actions/XMLDBAction.class.php: call to edit_table_save->init()
                * line 67 of /admin/xmldb/actions/XMLDBAction.class.php: call to XMLDBAction->XMLDBAction()
                * line 70 of /admin/xmldb/index.php: call to XMLDBAction->__construct()

            Invalid get_string() identifier: 'incorrecttablename' or component 'xmldb'

                * line 5982 of /lib/moodlelib.php: call to debugging()
                * line 6536 of /lib/moodlelib.php: call to core_string_manager->get_string()
                * line 138 of /admin/xmldb/actions/XMLDBAction.class.php: call to get_string()
                * line 48 of /admin/xmldb/actions/edit_table_save/edit_table_save.class.php: call to XMLDBAction->loadStrings()
                * line 60 of /admin/xmldb/actions/XMLDBAction.class.php: call to edit_table_save->init()
                * line 67 of /admin/xmldb/actions/XMLDBAction.class.php: call to XMLDBAction->XMLDBAction()
                * line 70 of /admin/xmldb/index.php: call to XMLDBAction->__construct()

            Invalid get_string() identifier: 'duplicatetablename' or component 'xmldb'

                * line 5982 of /lib/moodlelib.php: call to debugging()
                * line 6536 of /lib/moodlelib.php: call to core_string_manager->get_string()
                * line 138 of /admin/xmldb/actions/XMLDBAction.class.php: call to get_string()
                * line 48 of /admin/xmldb/actions/edit_table_save/edit_table_save.class.php: call to XMLDBAction->loadStrings()
                * line 60 of /admin/xmldb/actions/XMLDBAction.class.php: call to edit_table_save->init()
                * line 67 of /admin/xmldb/actions/XMLDBAction.class.php: call to XMLDBAction->XMLDBAction()
                * line 70 of /admin/xmldb/index.php: call to XMLDBAction->__construct()
            The following notices appear when you try to rename a table using the XMLDB editor

            Invalid get_string() identifier: 'tablenameempty' or component 'xmldb'

                * line 5982 of /lib/moodlelib.php: call to debugging()
                * line 6536 of /lib/moodlelib.php: call to core_string_manager->get_string()
                * line 138 of /admin/xmldb/actions/XMLDBAction.class.php: call to get_string()
                * line 48 of /admin/xmldb/actions/edit_table_save/edit_table_save.class.php: call to XMLDBAction->loadStrings()
                * line 60 of /admin/xmldb/actions/XMLDBAction.class.php: call to edit_table_save->init()
                * line 67 of /admin/xmldb/actions/XMLDBAction.class.php: call to XMLDBAction->XMLDBAction()
                * line 70 of /admin/xmldb/index.php: call to XMLDBAction->__construct()

            Invalid get_string() identifier: 'incorrecttablename' or component 'xmldb'

                * line 5982 of /lib/moodlelib.php: call to debugging()
                * line 6536 of /lib/moodlelib.php: call to core_string_manager->get_string()
                * line 138 of /admin/xmldb/actions/XMLDBAction.class.php: call to get_string()
                * line 48 of /admin/xmldb/actions/edit_table_save/edit_table_save.class.php: call to XMLDBAction->loadStrings()
                * line 60 of /admin/xmldb/actions/XMLDBAction.class.php: call to edit_table_save->init()
                * line 67 of /admin/xmldb/actions/XMLDBAction.class.php: call to XMLDBAction->XMLDBAction()
                * line 70 of /admin/xmldb/index.php: call to XMLDBAction->__construct()

            Invalid get_string() identifier: 'duplicatetablename' or component 'xmldb'

                * line 5982 of /lib/moodlelib.php: call to debugging()
                * line 6536 of /lib/moodlelib.php: call to core_string_manager->get_string()
                * line 138 of /admin/xmldb/actions/XMLDBAction.class.php: call to get_string()
                * line 48 of /admin/xmldb/actions/edit_table_save/edit_table_save.class.php: call to XMLDBAction->loadStrings()
                * line 60 of /admin/xmldb/actions/XMLDBAction.class.php: call to edit_table_save->init()
                * line 67 of /admin/xmldb/actions/XMLDBAction.class.php: call to XMLDBAction->XMLDBAction()
                * line 70 of /admin/xmldb/index.php: call to XMLDBAction->__construct()
            Database [Any]
            Pull 2.1 Branch mdl-23006-xmldb-missing-strings-m21
            Pull 2.1 Diff URL https://github.com/sbourget/moodle/compare/MOODLE_21_STABLE...mdl-29564-mdl-23006-xmldb-missing-strings-m21
            Pull from Repository git://github.com/sbourget/moodle.git
            Labels patch
            sbourget Stephen Bourget made changes -
            Affects Version/s 2.1.1 [ 10750 ]
            sbourget Stephen Bourget made changes -
            Assignee Eloy Lafuente (stronk7) [ stronk7 ] Stephen Bourget [ sbourget ]
            sbourget Stephen Bourget made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            Peer reviewer stronk7
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            sbourget Stephen Bourget made changes -
            Summary Missing Strings in XMLDB Editor Missing strings on table edit in XMLDB Editor
            sbourget Stephen Bourget made changes -
            Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
            Fix Version/s 2.1.3 [ 11251 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Link This issue has been marked as being related by MDL-30367 [ MDL-30367 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator stronk7
            Currently in integration Yes [ 10041 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Affects Version/s 2.2 [ 10656 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester stronk7
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 21/Nov/11
            salvetore Michael de Raadt made changes -
            Link This issue is duplicated by MDL-30367 [ MDL-30367 ]
            salvetore Michael de Raadt made changes -
            Link This issue is duplicated by MDL-32436 [ MDL-32436 ]
            salvetore Michael de Raadt made changes -
            Link This issue is duplicated by MDL-32436 [ MDL-32436 ]

              People

              • Assignee:
                sbourget Stephen Bourget
                Reporter:
                sbourget Stephen Bourget
                Peer reviewer:
                Eloy Lafuente (stronk7)
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Eloy Lafuente (stronk7)
                Participants:
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  28/Nov/11