Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Enrolments
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      32811

      Description

      The idea is to completely remove role_assignment interface at the course level, we already have enrolled users UI which allows users to assign roles and groups.
      The only potential problem is how to remove course administrators and other system wide people that teachers should not see.

      The current logic is in other areas is:
      1/ course participants page (/user/index.php) that is the page where both teachers and users see other course participants and their roles, we should only people with profile roles specified in $CFG->profileroles (usually tacher, editing teacher and student role); separate groups are in effect
      2/ enrolled users UI (/enrol/users.php) this is intended for editing teachers only with right to see and usually manage all course enrolments

      There is already a stub file in /enrol/otherusers.php - I suppose we should create a new capability which grants access to this information.

      UI features:
      1/ view all users in course or parent context
      2/ add and remove roles

      1. MDL-23117.20100715.02.patch
        94 kB
        Sam Hemelryk
      2. MDL-23117.20100716.01.patch
        96 kB
        Sam Hemelryk
      1. sprite.png
        1.0 kB

        Activity

        Hide
        Martin Dougiamas added a comment -

        I copied this from MDL-22854 which ended up being for something else.

        Show
        Martin Dougiamas added a comment - I copied this from MDL-22854 which ended up being for something else.
        Hide
        Sam Hemelryk added a comment -

        Hi guys,

        I've just attached the patch for this issue.

        The image needs to be copied to moodle/enrol/yui/otherusersmanager/assets/skins/sam/sprite.png

        The patch does two things essentially, first it addresses the other users page, which is operational and includes a YUI module to search and assign roles to users. It also allows in page role assign/unassign for existing `other` users.

        Second it introduces a set of JavaScript dialogues (YUI/moodle modules) to handle standard dialogue requirements such as alert, confirm, and panel as well as exception and AJAX exception (A PHP exception passed to the client.).
        As part of this I converted the enrol modules to make use of it and converted the ajax.php script to throw exceptions for all errors which can be easily picked up and dealt with in JavaScript.

        I would really like a review on this before it gets commit, if the dialogues are liked and it is decided to use them everywhere we should probably move them from enrol to somewhere more appropriate... maybe messaging, I'm open to ideas if this is the case.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi guys, I've just attached the patch for this issue. The image needs to be copied to moodle/enrol/yui/otherusersmanager/assets/skins/sam/sprite.png The patch does two things essentially, first it addresses the other users page, which is operational and includes a YUI module to search and assign roles to users. It also allows in page role assign/unassign for existing `other` users. Second it introduces a set of JavaScript dialogues (YUI/moodle modules) to handle standard dialogue requirements such as alert, confirm, and panel as well as exception and AJAX exception (A PHP exception passed to the client.). As part of this I converted the enrol modules to make use of it and converted the ajax.php script to throw exceptions for all errors which can be easily picked up and dealt with in JavaScript. I would really like a review on this before it gets commit, if the dialogues are liked and it is decided to use them everywhere we should probably move them from enrol to somewhere more appropriate... maybe messaging, I'm open to ideas if this is the case. Cheers Sam
        Hide
        Sam Hemelryk added a comment -

        Have attached the latest patch for this issue, it fixes a couple of minor bug plus all of the cross browser positioning bugs.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Have attached the latest patch for this issue, it fixes a couple of minor bug plus all of the cross browser positioning bugs. Cheers Sam
        Hide
        Petr Škoda added a comment -

        reading...

        Show
        Petr Škoda added a comment - reading...
        Hide
        Petr Škoda added a comment -

        +1 for commit, looks ok

        Show
        Petr Škoda added a comment - +1 for commit, looks ok
        Hide
        Sam Hemelryk added a comment -

        Thanks for looking at the patch Petr, the code has now been commit.
        At the same time this resolved a couple of other issues as well.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Thanks for looking at the patch Petr, the code has now been commit. At the same time this resolved a couple of other issues as well. Cheers Sam

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: