Moodle
  1. Moodle
  2. MDL-23126

cas - domxml-php4-to-php5.php typo, missing $this-> in call to append_child

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.9
    • Fix Version/s: 1.9.10, 2.0
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Rank:
      27100

      Description

      cas authentication module, file auth/cas/CAS/CAS/domxml-php4-to-php5.php, line 266 should be:

      function add_child($newnode)

      {return $this->append_child($newnode);}

        Activity

        Hide
        Petr Škoda added a comment -

        fixed, thanks!

        Show
        Petr Škoda added a comment - fixed, thanks!
        Hide
        Iñaki Arenaza added a comment -

        FYI, I've opened a bug upstream (https://issues.jasig.org/browse/PHPCAS-73) to notify them about this.

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - FYI, I've opened a bug upstream ( https://issues.jasig.org/browse/PHPCAS-73 ) to notify them about this. Saludos. Iñaki.
        Hide
        Iñaki Arenaza added a comment -

        By the way, this fix should be applied to HEAD too

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - By the way, this fix should be applied to HEAD too Saludos. Iñaki.
        Hide
        Joachim Fritschi added a comment -

        Fixed upstream and included in the 1.1-stable branch. Will be included in the next release. Thanks

        Show
        Joachim Fritschi added a comment - Fixed upstream and included in the 1.1-stable branch. Will be included in the next release. Thanks
        Hide
        Iñaki Arenaza added a comment -

        Fix applied to HEAD as part of MDL-23645.

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - Fix applied to HEAD as part of MDL-23645. Saludos. Iñaki.
        Hide
        Iñaki Arenaza added a comment -

        Fixed in CVS.

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - Fixed in CVS. Saludos. Iñaki.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: