Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Wiki (2.x)
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      36029

      Description

      require_course_login() is designed for resources that should be accessible on the frontpage without login BUT those are not pages that allow you to modify something. Luckily it is not a huge security problem in 2.0 anymore because we are forcing readonly access for guest account and not logged in users.

      Anyway please keep the require_course_login() on pages like view.php history.php (reading) and switch to normal require_login() in edit.php, comments.php, etc. (writing).

        Activity

        Hide
        Jordi Piguillem Poch added a comment -

        Fixed.

        Replaced at create.php, edit.php, editcomments.php, ,instancecomments.php, overridelocks.php and restoreversion.php.

        Show
        Jordi Piguillem Poch added a comment - Fixed. Replaced at create.php, edit.php, editcomments.php, ,instancecomments.php, overridelocks.php and restoreversion.php.
        Hide
        Petr Škoda added a comment - - edited

        Hello,
        looks like there is a fatal error from "require__login" - double underscore.

        Petr Skoda

        Show
        Petr Škoda added a comment - - edited Hello, looks like there is a fatal error from "require__login" - double underscore. Petr Skoda
        Hide
        Petr Škoda added a comment -

        also please use require_login($course instead of $course->id

        Show
        Petr Škoda added a comment - also please use require_login($course instead of $course->id
        Hide
        Jordi Piguillem Poch added a comment -

        Fixed.

        Show
        Jordi Piguillem Poch added a comment - Fixed.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: