[MDL-23219] Check System Permissions function seems a bit useless - Moodle Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0, 2.1
Fix Version/s: 2.2.5, 2.3.2
Component/s: Administration
Labels:
- partner
- ui_change

Testing Instructions:

Hide

Try this in various contexts.

1. Go to Settings -> Users -> Permissions -> Check permission (that is the location on a course page, it is slightly different in system / categories / modules).

2. Select a user (you should probably try this for various different users).

3. Verify that, at the top of the summary of the user's permissions, it shows all the user's roles in this context or parent contexts, including 'authenticated user', 'front page role', etc.

4. Role should be shown with a link to view the role definition of that role (if you have permissions to do that) and with a link that takes you to the context in question.

Show
Try this in various contexts. 1. Go to Settings -> Users -> Permissions -> Check permission (that is the location on a course page, it is slightly different in system / categories / modules). 2. Select a user (you should probably try this for various different users). 3. Verify that, at the top of the summary of the user's permissions, it shows all the user's roles in this context or parent contexts, including 'authenticated user', 'front page role', etc. 4. Role should be shown with a link to view the role definition of that role (if you have permissions to do that) and with a link that takes you to the context in question.
Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-23219~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-23219
Documentation link:
http://docs.moodle.org/23/en/Permissions#Checking_permissions

Description

Surely "Check System Permissions" would be much more use if it showed what roles a user was assigned to? Even the title is wrong - it shows a list of capabilities. 99 times out of 100 any role problems come down to having forgotten about assigning a user in some strange context. This is only going to half help with this. Ideally it should show both the capabilities and a simple list of role assignments for that user.

Gliffy Diagrams

Attachments

Issue Links

is blocked by

MDL-8249 Localised standard role names and descriptions

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Tim Hunt added a comment - 06/Jul/12 7:33 PM

Petr, this looks like your sort of thing, which is why I am asking you to peer-review. However, if you are too busy, feel free to shunt it over to Moodle HQ.

I am not sure if the new methods I added to accesslib.php are really a good idea, but they seemed like generally useful methods, which is why I put them there.

Show

Tim Hunt added a comment - 06/Jul/12 7:33 PM Petr, this looks like your sort of thing, which is why I am asking you to peer-review. However, if you are too busy, feel free to shunt it over to Moodle HQ. I am not sure if the new methods I added to accesslib.php are really a good idea, but they seemed like generally useful methods, which is why I put them there.

Hide

Permalink

Tim Hunt added a comment - 06/Jul/12 7:49 PM

I just posted about this in the roles forum, to warn people about the proposed change: http://moodle.org/mod/forum/discuss.php?d=206416

Since this is a new feature, it really ought to be 2.4 only. However, I bet a lot of people, OU included, would like this in 2.2+.

Show

Tim Hunt added a comment - 06/Jul/12 7:49 PM I just posted about this in the roles forum, to warn people about the proposed change: http://moodle.org/mod/forum/discuss.php?d=206416 Since this is a new feature, it really ought to be 2.4 only. However, I bet a lot of people, OU included, would like this in 2.2+.

Hide

Permalink

Petr Skoda added a comment - 06/Jul/12 9:09 PM - edited

Hi, I agree this report should be improved, listing of "effective" roles is good idea (that is roles in current context, parents and implicit roles). In any case I think we should start implementing any role related changes after ~~MDL-8249~~. Thanks for the report and +1 after ~~MDL-8249~~ lands.

Show

Petr Skoda added a comment - 06/Jul/12 9:09 PM - edited Hi, I agree this report should be improved, listing of "effective" roles is good idea (that is roles in current context, parents and implicit roles). In any case I think we should start implementing any role related changes after MDL-8249 . Thanks for the report and +1 after MDL-8249 lands.

Hide

Permalink

Tim Hunt added a comment - 07/Jul/12 3:05 PM

Ah, I had forgotten ~~MDL-8249~~ was up in the air. I will rebase once it has landed.

Show

Tim Hunt added a comment - 07/Jul/12 3:05 PM Ah, I had forgotten MDL-8249 was up in the air. I will rebase once it has landed.

Hide

Permalink

Tim Hunt added a comment - 13/Jul/12 10:26 PM

OK, rebased and submitting for integration.

Since this is a new feature, one could argue that it should be 2.4-only.

On the other hand, this is so bloody useful, and the UI change is hardly likely to confuse anyone, so I think it should go into all supported branches, hence I made commits for each stable branch.

I will respect the decision of the integrators about this.

Show

Tim Hunt added a comment - 13/Jul/12 10:26 PM OK, rebased and submitting for integration. Since this is a new feature, one could argue that it should be 2.4-only. On the other hand, this is so bloody useful, and the UI change is hardly likely to confuse anyone, so I think it should go into all supported branches, hence I made commits for each stable branch. I will respect the decision of the integrators about this.

Hide

Permalink

Tim Hunt added a comment - 13/Jul/12 10:29 PM

Docs need to be added at the other end of the Documentation link I gave. We need to wait and see which branches will need the change.

Show

Tim Hunt added a comment - 13/Jul/12 10:29 PM Docs need to be added at the other end of the Documentation link I gave. We need to wait and see which branches will need the change.

Hide

Permalink

Mary Cooch added a comment - 14/Jul/12 3:47 AM

I like this one

Show

Mary Cooch added a comment - 14/Jul/12 3:47 AM I like this one

Hide

Permalink

Ben Reynolds added a comment - 14/Jul/12 3:53 AM

Me, too, Moodlefairy.

Show

Ben Reynolds added a comment - 14/Jul/12 3:53 AM Me, too, Moodlefairy.

Hide

Permalink

Martin Dougiamas added a comment - 16/Jul/12 2:11 PM

+1 for stable as well, back to 2.2.

Show

Martin Dougiamas added a comment - 16/Jul/12 2:11 PM +1 for stable as well, back to 2.2.

Hide

Permalink

Dan Poltawski added a comment - 16/Jul/12 2:34 PM

Integrated to 22, 23 and master.

Thanks Tim!

Show

Dan Poltawski added a comment - 16/Jul/12 2:34 PM Integrated to 22, 23 and master. Thanks Tim!

Hide

Permalink

Adrian Greeve added a comment - 18/Jul/12 11:36 AM

Tested in 2.1, 2.2, and master
I assigned users multiple roles (student, teacher, manager, non-editing teacher) which all show up on the permission page.
All the links lead to the appropriate pages.
No problems encountered.
Test passed

Show

Adrian Greeve added a comment - 18/Jul/12 11:36 AM Tested in 2.1, 2.2, and master I assigned users multiple roles (student, teacher, manager, non-editing teacher) which all show up on the permission page. All the links lead to the appropriate pages. No problems encountered. Test passed

Hide

Permalink

Dan Poltawski added a comment - 19/Jul/12 2:43 PM

*Notice*: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26

Congratulations

{tracker.user.name}

You've made into Moodle

{tracker.fixversion-1}

I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world.

cheers!

{tracker.friendlyintegrator}

Show

Dan Poltawski added a comment - 19/Jul/12 2:43 PM * Notice *: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26 Congratulations {tracker.user.name} ! You've made into Moodle {tracker.fixversion-1} + I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world. cheers! {tracker.friendlyintegrator}

Hide

Permalink

Helen Foster added a comment - 20/Jul/12 4:53 AM

Documentation plus updated screenshot added to http://docs.moodle.org/23/en/Permissions and http://docs.moodle.org/22/en/Permissions

Thanks Tim

Show

Helen Foster added a comment - 20/Jul/12 4:53 AM Documentation plus updated screenshot added to http://docs.moodle.org/23/en/Permissions and http://docs.moodle.org/22/en/Permissions Thanks Tim

People

Assignee:

Tim Hunt

Reporter:

Howard Miller

Peer reviewer:

Petr Skoda

Integrator:

Dan Poltawski

Tester:

Adrian Greeve

Participants:

Adrian Greeve, Ben Reynolds, Dan Poltawski, Helen Foster, Howard Miller, Martin Dougiamas, Mary Cooch, Petr Skoda, Tim Hunt

Votes:

7 Vote for this issue

Watchers:

5 Start watching this issue

Dates

Created:

12/Jul/10 6:21 PM

Updated:

20/Jul/12 4:53 AM

Resolved:

19/Jul/12 2:43 PM

Fix Release Date:

10/Sep/12