Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23219

Check System Permissions function seems a bit useless

    Details

    • Testing Instructions:
      Hide

      Try this in various contexts.

      1. Go to Settings -> Users -> Permissions -> Check permission (that is the location on a course page, it is slightly different in system / categories / modules).

      2. Select a user (you should probably try this for various different users).

      3. Verify that, at the top of the summary of the user's permissions, it shows all the user's roles in this context or parent contexts, including 'authenticated user', 'front page role', etc.

      4. Role should be shown with a link to view the role definition of that role (if you have permissions to do that) and with a link that takes you to the context in question.

      Show
      Try this in various contexts. 1. Go to Settings -> Users -> Permissions -> Check permission (that is the location on a course page, it is slightly different in system / categories / modules). 2. Select a user (you should probably try this for various different users). 3. Verify that, at the top of the summary of the user's permissions, it shows all the user's roles in this context or parent contexts, including 'authenticated user', 'front page role', etc. 4. Role should be shown with a link to view the role definition of that role (if you have permissions to do that) and with a link that takes you to the context in question.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Surely "Check System Permissions" would be much more use if it showed what roles a user was assigned to? Even the title is wrong - it shows a list of capabilities. 99 times out of 100 any role problems come down to having forgotten about assigning a user in some strange context. This is only going to half help with this. Ideally it should show both the capabilities and a simple list of role assignments for that user.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            Petr, this looks like your sort of thing, which is why I am asking you to peer-review. However, if you are too busy, feel free to shunt it over to Moodle HQ.

            I am not sure if the new methods I added to accesslib.php are really a good idea, but they seemed like generally useful methods, which is why I put them there.

            Show
            timhunt Tim Hunt added a comment - Petr, this looks like your sort of thing, which is why I am asking you to peer-review. However, if you are too busy, feel free to shunt it over to Moodle HQ. I am not sure if the new methods I added to accesslib.php are really a good idea, but they seemed like generally useful methods, which is why I put them there.
            Hide
            timhunt Tim Hunt added a comment -

            I just posted about this in the roles forum, to warn people about the proposed change: http://moodle.org/mod/forum/discuss.php?d=206416

            Since this is a new feature, it really ought to be 2.4 only. However, I bet a lot of people, OU included, would like this in 2.2+.

            Show
            timhunt Tim Hunt added a comment - I just posted about this in the roles forum, to warn people about the proposed change: http://moodle.org/mod/forum/discuss.php?d=206416 Since this is a new feature, it really ought to be 2.4 only. However, I bet a lot of people, OU included, would like this in 2.2+.
            Hide
            skodak Petr Skoda added a comment - - edited

            Hi, I agree this report should be improved, listing of "effective" roles is good idea (that is roles in current context, parents and implicit roles). In any case I think we should start implementing any role related changes after MDL-8249. Thanks for the report and +1 after MDL-8249 lands.

            Show
            skodak Petr Skoda added a comment - - edited Hi, I agree this report should be improved, listing of "effective" roles is good idea (that is roles in current context, parents and implicit roles). In any case I think we should start implementing any role related changes after MDL-8249 . Thanks for the report and +1 after MDL-8249 lands.
            Hide
            timhunt Tim Hunt added a comment -

            Ah, I had forgotten MDL-8249 was up in the air. I will rebase once it has landed.

            Show
            timhunt Tim Hunt added a comment - Ah, I had forgotten MDL-8249 was up in the air. I will rebase once it has landed.
            Hide
            timhunt Tim Hunt added a comment -

            OK, rebased and submitting for integration.

            Since this is a new feature, one could argue that it should be 2.4-only.

            On the other hand, this is so bloody useful, and the UI change is hardly likely to confuse anyone, so I think it should go into all supported branches, hence I made commits for each stable branch.

            I will respect the decision of the integrators about this.

            Show
            timhunt Tim Hunt added a comment - OK, rebased and submitting for integration. Since this is a new feature, one could argue that it should be 2.4-only. On the other hand, this is so bloody useful, and the UI change is hardly likely to confuse anyone, so I think it should go into all supported branches, hence I made commits for each stable branch. I will respect the decision of the integrators about this.
            Hide
            timhunt Tim Hunt added a comment -

            Docs need to be added at the other end of the Documentation link I gave. We need to wait and see which branches will need the change.

            Show
            timhunt Tim Hunt added a comment - Docs need to be added at the other end of the Documentation link I gave. We need to wait and see which branches will need the change.
            Hide
            marycooch Mary Cooch added a comment -

            I like this one

            Show
            marycooch Mary Cooch added a comment - I like this one
            Hide
            benreynolds Ben Reynolds added a comment -

            Me, too, Moodlefairy.

            Show
            benreynolds Ben Reynolds added a comment - Me, too, Moodlefairy.
            Hide
            dougiamas Martin Dougiamas added a comment -

            +1 for stable as well, back to 2.2.

            Show
            dougiamas Martin Dougiamas added a comment - +1 for stable as well, back to 2.2.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to 22, 23 and master.

            Thanks Tim!

            Show
            poltawski Dan Poltawski added a comment - Integrated to 22, 23 and master. Thanks Tim!
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested in 2.1, 2.2, and master
            I assigned users multiple roles (student, teacher, manager, non-editing teacher) which all show up on the permission page.
            All the links lead to the appropriate pages.
            No problems encountered.
            Test passed

            Show
            abgreeve Adrian Greeve added a comment - Tested in 2.1, 2.2, and master I assigned users multiple roles (student, teacher, manager, non-editing teacher) which all show up on the permission page. All the links lead to the appropriate pages. No problems encountered. Test passed
            Hide
            poltawski Dan Poltawski added a comment -

            *Notice*: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26

            Congratulations

            {tracker.user.name}

            !

            You've made into Moodle

            {tracker.fixversion-1}

            +

            I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world.

            cheers!

            {tracker.friendlyintegrator}
            Show
            poltawski Dan Poltawski added a comment - * Notice *: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26 Congratulations {tracker.user.name} ! You've made into Moodle {tracker.fixversion-1} + I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world. cheers! {tracker.friendlyintegrator}
            Hide
            tsala Helen Foster added a comment -

            Documentation plus updated screenshot added to http://docs.moodle.org/23/en/Permissions and http://docs.moodle.org/22/en/Permissions

            Thanks Tim

            Show
            tsala Helen Foster added a comment - Documentation plus updated screenshot added to http://docs.moodle.org/23/en/Permissions and http://docs.moodle.org/22/en/Permissions Thanks Tim

              People

              • Votes:
                7 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12