Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Repositories
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      32818

      Description

      List of problems found in repo/upload

      1/ you can not urldecode after clean_param - it does not make any sense because the urldecode completely sidesteps the cleaning
      2/ do not use file browser there
      3/ $_FILES[$elname]['name'] needs to cleaned, otherwise users will not be able to upload some files at all
      4/ file overriding is a problem there, if you have a picture in draft area already and you upload different picture with the same name the origianl one will change

        Activity

        Hide
        Petr Škoda added a comment -

        reopening,
        1/ the repository/recent still overrides files without any warning or error
        2/ repository local does not check if file exists
        3/ move_to_filepool deletes without waring too

        I think all the plugins should react the same when file already exists == give consistent errors/warnings

        Show
        Petr Škoda added a comment - reopening, 1/ the repository/recent still overrides files without any warning or error 2/ repository local does not check if file exists 3/ move_to_filepool deletes without waring too I think all the plugins should react the same when file already exists == give consistent errors/warnings

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: