Moodle
  1. Moodle
  2. MDL-23322

install.php not handling environment check consistently

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Administration
    • Labels:
      None
    • Environment:
      Debian 5.0.5 dev setup. Apache2, mySQL, moodle-latest.tgz 2.0 Preview 4 build 20100715
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      2666

      Description

      Running install.php as a fresh install.
      Apache configured to use moodle.dev URL
      First page presents ok for Language selection.
      Selecting English (en) moves to a Environment Check Failed page which has what will be constants for language conversion that are not being populated. [[environment]] and [[environmentrequireversion]] which I think means that there is an issue with my PHP version but I am not being told what that is.
      However, if I then go back and select English (en_us) I get the same page but with the added issue of cURL PHP Extension [[environmentrequireinstall]] Noting also that the reload button has [[reload]] as its text.

      Summary:
      #1 - Environment Check page not presenting reasons for failure
      #2 - Environment Check is inconsistent between selected interface languages

        Activity

        Hide
        Petr Škoda added a comment -

        David: could you please review this?

        Show
        Petr Škoda added a comment - David: could you please review this?
        Hide
        Tony Howden added a comment -

        Update on the install. After I updated / upgraded Debian including PHP upgrade the install runs fine.

        Show
        Tony Howden added a comment - Update on the install. After I updated / upgraded Debian including PHP upgrade the install runs fine.
        Hide
        David Mudrak added a comment -

        Hi,

        this is a bit weird. If you were really using PHP 5.0.5, Moodle installator should not even start as it requires PHP 5.2.0 to run at least environment checks, where (at the moment) PHP 5.2.8 is required. The issue with the strings in double brackets is weird, too, as it means that the installer was not able to find English strings which are part of the installation. I guess something really messy had to happen there that time.

        Anyway, goo to hear that upgrade helped. I am resolving this issue. Thanks for the report.

        Show
        David Mudrak added a comment - Hi, this is a bit weird. If you were really using PHP 5.0.5, Moodle installator should not even start as it requires PHP 5.2.0 to run at least environment checks, where (at the moment) PHP 5.2.8 is required. The issue with the strings in double brackets is weird, too, as it means that the installer was not able to find English strings which are part of the installation. I guess something really messy had to happen there that time. Anyway, goo to hear that upgrade helped. I am resolving this issue. Thanks for the report.
        Hide
        Borys added a comment -

        Hi,

        Same problem here. Upgrading Debian to Lenny did not help. All I get is [[environmentrequireversion]], [[environment]] and [[reload]] button. Changing the installation language also doesn't help. I'm using the latest 2.0 package from yesterday.

        PHP Version 5.2.6-1+lenny8
        This server is protected with the Suhosin Patch 0.9.6.2

        1. lighttpd -v
          lighttpd/1.4.26 (ssl) - a light and fast webserver
          Build-Date: Mar 17 2010 14:37:13
        1. uname -r
          2.6.18-6-amd64

        I'll search for PHP 5.2.8-amd64. But you've stated that at least the environment checks should start...

        Show
        Borys added a comment - Hi, Same problem here. Upgrading Debian to Lenny did not help. All I get is [ [environmentrequireversion] ], [ [environment] ] and [ [reload] ] button. Changing the installation language also doesn't help. I'm using the latest 2.0 package from yesterday. PHP Version 5.2.6-1+lenny8 This server is protected with the Suhosin Patch 0.9.6.2 lighttpd -v lighttpd/1.4.26 (ssl) - a light and fast webserver Build-Date: Mar 17 2010 14:37:13 uname -r 2.6.18-6-amd64 I'll search for PHP 5.2.8-amd64. But you've stated that at least the environment checks should start...
        Hide
        David Mudrak added a comment -

        Reopening, I just spotted some weird issues with the installer strings generator

        Show
        David Mudrak added a comment - Reopening, I just spotted some weird issues with the installer strings generator
        Hide
        Tony Howden added a comment -

        hi

        Sorry it was not PHP 5.0.5 but Debian Etch 5.0.5 which is PHP 5.2.(something less than required)

        The upgrade to Debian Lenny was insufficient as it remains as PHP 5.2.6 and I did apply an upgrade to PHP to 5.2.8 or something higher.

        Tony

        Show
        Tony Howden added a comment - hi Sorry it was not PHP 5.0.5 but Debian Etch 5.0.5 which is PHP 5.2.(something less than required) The upgrade to Debian Lenny was insufficient as it remains as PHP 5.2.6 and I did apply an upgrade to PHP to 5.2.8 or something higher. Tony
        Hide
        David Mudrak added a comment -

        Confirmed, we have incorrect installer string definitions in install/stringnames.txt

        ERROR Unknown admindir,install
        ERROR Unknown environment,install
        ERROR Unknown environmentrequireinstall,install
        ERROR Unknown environmentrequireversion,install
        ERROR Unknown reload,admin
        

        I am going to fix them now.

        Show
        David Mudrak added a comment - Confirmed, we have incorrect installer string definitions in install/stringnames.txt ERROR Unknown admindir,install ERROR Unknown environment,install ERROR Unknown environmentrequireinstall,install ERROR Unknown environmentrequireversion,install ERROR Unknown reload,admin I am going to fix them now.
        Hide
        David Mudrak added a comment -

        @Tony: thanks for the update. I just committed a patch that should fix the issue #1 - that is you should now see proper reasons of the fail instead of the string codes in double brackets. Please re-try to install and let me know what error you see now.

        @Borys: thanks for the info

        Show
        David Mudrak added a comment - @Tony: thanks for the update. I just committed a patch that should fix the issue #1 - that is you should now see proper reasons of the fail instead of the string codes in double brackets. Please re-try to install and let me know what error you see now. @Borys: thanks for the info
        Hide
        Borys added a comment -

        Much better now, at least it's failing in an expected way

        So the search for PHP 5.2.8-amd64 continues...

        Show
        Borys added a comment - Much better now, at least it's failing in an expected way So the search for PHP 5.2.8-amd64 continues...
        Hide
        David Mudrak added a comment -

        This issue was assigned to me, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

        Show
        David Mudrak added a comment - This issue was assigned to me, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
        Hide
        Petr Škoda added a comment -

        Closing, thanks.

        Show
        Petr Škoda added a comment - Closing, thanks.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: