Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23371

auth/ldap and auth/cas refactor

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      I've refactored auth/ldap and auth/cas quite a bit. They now share most of the code, and they share some code with enrol/ldap. They have also gained some features and a few fixes. You can get a copy of the new code from http://github.com/iarenaza/moodle/tree/HEAD_LDAP_REFACTOR/

      Saludos.
      Iñaki.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              skodak Petr Skoda added a comment -

              ah, I overlooked this, going to review it in few hours, in general I would like to get this into RC1

              Show
              skodak Petr Skoda added a comment - ah, I overlooked this, going to review it in few hours, in general I would like to get this into RC1
              Hide
              skodak Petr Skoda added a comment -

              +1 I already reviewed this together with enrol/ldap

              Show
              skodak Petr Skoda added a comment - +1 I already reviewed this together with enrol/ldap
              Hide
              iarenaza Iñaki Arenaza added a comment -

              Changes now in HEAD.

              Saludos.
              Iñaki.

              Show
              iarenaza Iñaki Arenaza added a comment - Changes now in HEAD. Saludos. Iñaki.
              Hide
              tlock Tim Lock added a comment -

              Hi All,

              Just playing around with upgrading from 1.9 to 2.0 with 3 courses and found this error :-

              ++ Success ++
              -->auth_cas
              ++ Success ++
              -->auth_db
              ++ Success ++
              -->auth_fc
              ++ Success ++
              -->auth_imap
              ++ Success ++
              -->auth_ldap
              PHP Fatal error: Cannot redeclare xmldb_auth_cas_install() (previously declared in /moodle20-dev/auth/cas/db/install.php:4) in /git/moodle2/moodle20-dev/auth/ldap/db/install.php on line 24

              Fatal error: Cannot redeclare xmldb_auth_cas_install() (previously declared in /moodle20-dev/auth/cas/db/install.php:4) in /git/moodle2/moodle20-dev/auth/ldap/db/install.php on line 24

              Build: 20100726

              function xmldb_auth_cas_install() {

              needs to be changed to in (auth/ldap/db/install.php) :-

              function xmldb_auth_ldap_install() {

              Show
              tlock Tim Lock added a comment - Hi All, Just playing around with upgrading from 1.9 to 2.0 with 3 courses and found this error :- ++ Success ++ -->auth_cas ++ Success ++ -->auth_db ++ Success ++ -->auth_fc ++ Success ++ -->auth_imap ++ Success ++ -->auth_ldap PHP Fatal error: Cannot redeclare xmldb_auth_cas_install() (previously declared in /moodle20-dev/auth/cas/db/install.php:4) in /git/moodle2/moodle20-dev/auth/ldap/db/install.php on line 24 Fatal error: Cannot redeclare xmldb_auth_cas_install() (previously declared in /moodle20-dev/auth/cas/db/install.php:4) in /git/moodle2/moodle20-dev/auth/ldap/db/install.php on line 24 Build: 20100726 function xmldb_auth_cas_install() { needs to be changed to in (auth/ldap/db/install.php) :- function xmldb_auth_ldap_install() {
              Hide
              ashleyholman Ashley Holman added a comment -

              re-opening due to Tim's bug report

              Show
              ashleyholman Ashley Holman added a comment - re-opening due to Tim's bug report
              Hide
              skodak Petr Skoda added a comment -

              hello, I have reverted the auth/ldap/db/install.php commit to previous version, please review

              Show
              skodak Petr Skoda added a comment - hello, I have reverted the auth/ldap/db/install.php commit to previous version, please review
              Hide
              iarenaza Iñaki Arenaza added a comment -

              Petr,

              thanks for taking care of this. I copied the install.php from cas by accident. The reverted version is the right one (there are no additional changes to apply).

              Closing this.

              Show
              iarenaza Iñaki Arenaza added a comment - Petr, thanks for taking care of this. I copied the install.php from cas by accident. The reverted version is the right one (there are no additional changes to apply). Closing this.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    24/Nov/10