Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23410

get_string missing a parameter in empty course search results

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Course
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      If you search for courses, and no results are returned, the get_string call used to generate the heading is missing a parameter, causing the search term to be used as the component to search for the string in.

      Line 344 of course/search.php needs to be changed from:
      echo $OUTPUT->heading(get_string("nocoursesfound", s($search)));
      to:
      echo $OUTPUT->heading(get_string("nocoursesfound", "", s($search)));

        Attachments

          Activity

            People

            • Assignee:
              nebgor Aparup Banerjee
              Reporter:
              paul.n Paul Nicholls
              Tester:
              Nobody
              Participants:
              Component watchers:
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10