Moodle
  1. Moodle
  2. MDL-23532

new enrol UI creates make core dependant on cohort and manual plugins

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Blocker Blocker
        • Resolution: Fixed
        • Affects Version/s: 2.0
        • Fix Version/s: None
        • Component/s: Enrolments
        • Labels:
          None
        • Affected Branches:
          MOODLE_20_STABLE

          Description

          After reading the code a bit more I think the new UI code+ajax is abstracted in a way that breaks the original enrolment plugability and code separation
          I think the UI+ajax related to manual enrolment should be in enrol/manual, the cohort enrol UI should be strictly in enrol/cohort - not in enrol/ directly.

          At present if you uninstall manual or cohort plugin the UI will not work, if somebody wants to replace those plugins with custom code the UI may break too.

          I think it would be great to allow other plugins to extend the "Enrolled users" page with custom ajax code

          There is no time to do this in 2.0, but I think this should be a priority for 2.1......

            Gliffy Diagrams

              Issue Links

              blocks

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-26770 "Extend enrolment" features missing from Moodle 2.x

              • Major - Major loss of function, incorrect output
              • Closed

              Improvement - An enhancement to an existing Moodle feature. MDL-27109 Allow enrolment plugins to override the actionable icons displayed on the enrol users screen

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Added to the sprint and raised priority, this is now a blocker to several other issues.

                Show
                Sam Hemelryk added a comment - Added to the sprint and raised priority, this is now a blocker to several other issues.
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Linking to MDL-26770

                Show
                Sam Hemelryk added a comment - Linking to MDL-26770
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Hi Petr,
                I have a preliminary patch for this, would you be able to have a look at it for me and let me know what you think?

                https://github.com/samhemelryk/moodle/compare/master...wip-MDL-23532-master

                The patch separates the enrolment UI from core enrol to the enrolment plugins and uses hooks to integrate back into the enrolled users screen.
                Essentially the enrolled users screen now only preforms role/group assignment actions.

                I also have a patch that builds upon this one that makes bulk operations possible but I would obviously like this reviewed and settled first.

                Cheers
                Sam

                Show
                Sam Hemelryk added a comment - Hi Petr, I have a preliminary patch for this, would you be able to have a look at it for me and let me know what you think? https://github.com/samhemelryk/moodle/compare/master...wip-MDL-23532-master The patch separates the enrolment UI from core enrol to the enrolment plugins and uses hooks to integrate back into the enrolled users screen. Essentially the enrolled users screen now only preforms role/group assignment actions. I also have a patch that builds upon this one that makes bulk operations possible but I would obviously like this reviewed and settled first. Cheers Sam
                Hide
                Permalink
                Petr Skoda added a comment -

                Great!!

                Show
                Petr Skoda added a comment - Great!!
                Hide
                Permalink
                Sam Hemelryk added a comment -

                I've rebased the patch after the weekly and re-applied Andrews changes where required in the manual enrol plugin (restore grades on enrol).

                Show
                Sam Hemelryk added a comment - I've rebased the patch after the weekly and re-applied Andrews changes where required in the manual enrol plugin (restore grades on enrol).
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Created PULL-688

                Show
                Sam Hemelryk added a comment - Created PULL-688

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: