Moodle
  1. Moodle
  2. MDL-23534

Suggestion to use Front Page short name instead of the language string

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.2
    • Component/s: Navigation
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Check that in the navigation your have a site pages node
      3. Browse to Settings > Appearance > Navigation
      4. Enable usesitenameforsitepages
      5. Check that in the navigation site pages has changed to your sites short name
      Show
      Log in as an admin Check that in the navigation your have a site pages node Browse to Settings > Appearance > Navigation Enable usesitenameforsitepages Check that in the navigation site pages has changed to your sites short name
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      wip-MDL-23534-master
    • Rank:
      6173

      Description

      Sam suggested I raise this as a tracker issue. That is to use the Frontpage Short Name instead of the language string 'Site pages' as it is at the moment.

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Thanks Mary, I've created a patch that adds a new setting to allow this.
          Not 100% sure everyone will like it but we'll see

          Show
          Sam Hemelryk added a comment - Thanks Mary, I've created a patch that adds a new setting to allow this. Not 100% sure everyone will like it but we'll see
          Hide
          Aparup Banerjee added a comment -

          yup this looks good to me. yay nicer node names.

          Show
          Aparup Banerjee added a comment - yup this looks good to me. yay nicer node names.
          Hide
          Sam Hemelryk added a comment -

          Up for integration now, will be included in Moodle 2.2 if it is integrated

          Show
          Sam Hemelryk added a comment - Up for integration now, will be included in Moodle 2.2 if it is integrated
          Hide
          Mary Evans added a comment -

          Great! I had forgotten about this...thanks Sam for fixing it and adding to Moodle 2.2.

          Show
          Mary Evans added a comment - Great! I had forgotten about this...thanks Sam for fixing it and adding to Moodle 2.2.
          Hide
          Petr Škoda added a comment -

          Why do we need yet another setting for this? Why should somebody not like the real short site name there?

          Show
          Petr Škoda added a comment - Why do we need yet another setting for this? Why should somebody not like the real short site name there?
          Hide
          Petr Škoda added a comment -

          We could just change it in master and wait if too many people complain. I am also thinking about the multi-tenant Moodle hack which would require us to use the site names more often instead of lang strings - you would want to know which sub-site is presently active.

          Show
          Petr Škoda added a comment - We could just change it in master and wait if too many people complain. I am also thinking about the multi-tenant Moodle hack which would require us to use the site names more often instead of lang strings - you would want to know which sub-site is presently active.
          Hide
          Mary Evans added a comment -

          Why should people complain? I thought the fact that you have the option to give your site a short name would work as it did in Moodle 1.9. What made it change in Moodle 2.0 anyway?

          Curiously...
          Mary

          Show
          Mary Evans added a comment - Why should people complain? I thought the fact that you have the option to give your site a short name would work as it did in Moodle 1.9. What made it change in Moodle 2.0 anyway? Curiously... Mary
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week due to time constraints. Thanks for your support and patience!

          Sorry and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week due to time constraints. Thanks for your support and patience! Sorry and ciao
          Hide
          Sam Hemelryk added a comment -

          Has now been rebased with conflict resolution

          Show
          Sam Hemelryk added a comment - Has now been rebased with conflict resolution
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Code is 100% ok... but:

          I'm going to reject this based on my own opinion:

          1) No sense to add this now to master as far as the multi-grrr (tenant) thing will revisit it.
          2) I see that change more suitable for stable branches (to ensure current behavior..). Else, if it goes to master only I'd skip the new setting and use the site/tenant shortname always.
          3) Let's MD decide and done. Martin could you, plz:

          a) Should this land into 21_STABLE (Y/N)
          b) Should this land to master (Y/N)
          c) if b), with setting (Y/N)
          d) if not b) should we wait for the multi implementation, and Petr add it to his code (Y/N)

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Code is 100% ok... but: I'm going to reject this based on my own opinion: 1) No sense to add this now to master as far as the multi-grrr (tenant) thing will revisit it. 2) I see that change more suitable for stable branches (to ensure current behavior..). Else, if it goes to master only I'd skip the new setting and use the site/tenant shortname always. 3) Let's MD decide and done. Martin could you, plz: a) Should this land into 21_STABLE (Y/N) b) Should this land to master (Y/N) c) if b), with setting (Y/N) d) if not b) should we wait for the multi implementation, and Petr add it to his code (Y/N) Ciao
          Hide
          Sam Hemelryk added a comment -

          Marking this issue blocked by the multi tenant issue then.
          I'll also re-assign to Petr so that he can keep track of it a make it a consideration during the development of the multi tenancy solution. Petr all yours
          Certainly I think if this is going to clash it should be looked at as part of that and I don't think this should land in stable for it lands in master so my +1 for the big delay!

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Marking this issue blocked by the multi tenant issue then. I'll also re-assign to Petr so that he can keep track of it a make it a consideration during the development of the multi tenancy solution. Petr all yours Certainly I think if this is going to clash it should be looked at as part of that and I don't think this should land in stable for it lands in master so my +1 for the big delay! Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          All yours for consideratio during multi-tenancy development Petr

          Show
          Sam Hemelryk added a comment - All yours for consideratio during multi-tenancy development Petr
          Hide
          Petr Škoda added a comment -

          resubmitting for integration, in multitenant mode we will simply use the tenant site name always.

          thanks a lot for the patch

          Show
          Petr Škoda added a comment - resubmitting for integration, in multitenant mode we will simply use the tenant site name always. thanks a lot for the patch
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr - I've rebased this patch now

          Show
          Sam Hemelryk added a comment - Thanks Petr - I've rebased this patch now
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Rossiani Wijaya added a comment -

          This works great. Thanks everyone.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This works great. Thanks everyone. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          YTC !

          (aka, yay, thanks and ciao ) Closing.

          Show
          Eloy Lafuente (stronk7) added a comment - YTC ! (aka, yay, thanks and ciao ) Closing.
          Hide
          Mary Evans added a comment -


          TY

          Show
          Mary Evans added a comment - TY

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: