Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21432 META: Backup & restore 2.0
  3. MDL-23547

improvement: build one static cache for get/set_get_backup_ids_record()

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Deferred
    • 2.0
    • None
    • Backup
    • MOODLE_20_STABLE
    • Moderate

    Description

      On restore, all the communication with the backup_ids_temp table happens using these two lowlevel functions:

      • get_backup_ids_record()
      • set_backup_ids_record()

      being called "zillions" of times for storing/retrieving records from that table.

      It would be great to have some cache (by backupid, itemname, itemid), caching results on retrieval and invalidating them on store. Surely one separate singleton-like instance. Should improve speed in restore a lot!

      Ciao

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: