Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23580

Unneeded tags and other junk printed in course overview

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.9, 2.0, 2.1, 2.2
    • Fix Version/s: 1.9.13, 2.0.4, 2.1.1
    • Component/s: General
    • Labels:
      None

      Description

      In admin/report/courseoverview/index.php, if the report doesn't generate any data (such as on our test server), you get some unneeded tags and some other junk (debugging message?).

      The offending code is in that file on line 83 and is a whopping 3.5 years old: http://git.moodle.org/gw?p=moodle.git;a=commitdiff;h=e524c0ed56125ecdafd24f868848b9eebffc99f7

      It looks like cvshead has it as well, on line 88.

      You can remove everything after the call to notify() and it works just fine here.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            LOL, crazy!

            Integrating that onto as many branches as possible, thanks!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - LOL, crazy! Integrating that onto as many branches as possible, thanks! Ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            (assigning to DanP)

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - (assigning to DanP)
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks! (19, 20, 21 and master)

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (19, 20, 21 and master)
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Passing test, I reproduced it and fix is obvious.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Passing test, I reproduced it and fix is obvious.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Congratulations - this fix has just been released in the weeklies.

            Show
            samhemelryk Sam Hemelryk added a comment - Congratulations - this fix has just been released in the weeklies.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11