Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23626

Student activity report location in nav block is weird

          Details

          • Type: Improvement
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.0
          • Fix Version/s: 2.2
          • Component/s: Navigation
          • Labels:
            None
          • Testing Instructions:
            Hide
            1. Log into a site as an admin
            2. Browse to a course
            3. In the navigation expand Course > Participants > Yourname > Activity reports and select Outline report
            4. Check that the correct item in the navigation is highlighted
            5. In the navigation expand My profile > Activity reports and select Outline report
            6. Check that the correct item in the navigation is highlighted
            Show
            Log into a site as an admin Browse to a course In the navigation expand Course > Participants > Yourname > Activity reports and select Outline report Check that the correct item in the navigation is highlighted In the navigation expand My profile > Activity reports and select Outline report Check that the correct item in the navigation is highlighted
          • Affected Branches:
            MOODLE_20_STABLE
          • Fixed Branches:
            MOODLE_22_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            wip-MDL-23626-master
          • Pull Master Diff URL:

            Description

            The location of the student activity reports in the nav block is weird. It is Navigation -> My courses -> Course name -> Participants -> (student name) -> Activity reports.

            If we're within My courses why do I need to select myself to get my activity reports? A more logical structure would be Navigation -> My courses -> Course name -> Activity reports

              Gliffy Diagrams

                Attachments

                  Issue Links

                  has a non-specific relationship to

                  Improvement - An enhancement to an existing Moodle feature. MDL-23609 Grades links overlap between the navigation and settings blocks

                  • Minor - Minor loss of function where workaround is possible
                  • Closed
                  has been marked as being related by

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28582 Outline and complete reports dont work when accessed from system context so probably shouldnt be in the navigation tree

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Hi Andrew,

                    I've just been looking at/thinking about this issue and presently whilst a little long winded I do think the users activity reports are in the correct place.

                    The reports are based upon the users personal context and in the case of a specific course they relate to the course context as well. The participants branch within a course is where this combination of user/course contexts is fused.
                    Unfortunately yes when viewing your own profile it is a little long winded.
                    Moving it to directly under the course node is possible but I'd rather avoid in order to keep the course node as clean and true to the course context.

                    In looking at this I did however find a bug, the user's activity reports were being marked as active in two places, the users course profile and the users full profile. This was because the users full profile was still referencing the current course.

                    Petr, I've attached a patch for this issue that sets the course to the site course and changes the navigations generation context to the front page course context for the users profile.
                    Could you please review it and let me know if it is OK to be commit.

                    Cheers
                    Sam

                    Show
                    samhemelryk Sam Hemelryk added a comment - Hi Andrew, I've just been looking at/thinking about this issue and presently whilst a little long winded I do think the users activity reports are in the correct place. The reports are based upon the users personal context and in the case of a specific course they relate to the course context as well. The participants branch within a course is where this combination of user/course contexts is fused. Unfortunately yes when viewing your own profile it is a little long winded. Moving it to directly under the course node is possible but I'd rather avoid in order to keep the course node as clean and true to the course context. In looking at this I did however find a bug, the user's activity reports were being marked as active in two places, the users course profile and the users full profile. This was because the users full profile was still referencing the current course. Petr, I've attached a patch for this issue that sets the course to the site course and changes the navigations generation context to the front page course context for the users profile. Could you please review it and let me know if it is OK to be commit. Cheers Sam
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Hi guys this bug still exists - submitting for peer-review now

                    Show
                    samhemelryk Sam Hemelryk added a comment - Hi guys this bug still exists - submitting for peer-review now
                    Hide
                    Permalink
                    nebgor Aparup Banerjee added a comment -

                    Yup code changes does exactly as was said.

                    Probably want to set Petr as reviewer if needed.
                    Also the issue has changed somewhat - maybe reflect that in title.

                    Show
                    nebgor Aparup Banerjee added a comment - Yup code changes does exactly as was said. Probably want to set Petr as reviewer if needed. Also the issue has changed somewhat - maybe reflect that in title.
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Thanks Apu.

                    Show
                    samhemelryk Sam Hemelryk added a comment - Thanks Apu.
                    Hide
                    Permalink
                    skodak Petr Skoda added a comment -

                    hello, I have integrated this change only into master branch, I think we should device after we get some feedback from the testers. It would be easy to revert this or later backport to stable.

                    Thanks!

                    Show
                    skodak Petr Skoda added a comment - hello, I have integrated this change only into master branch, I think we should device after we get some feedback from the testers. It would be easy to revert this or later backport to stable. Thanks!
                    Hide
                    Permalink
                    andyjdavis Andrew Davis added a comment -

                    After talking with Sam I'm passing this although I have raised MDL-28582

                    Show
                    andyjdavis Andrew Davis added a comment - After talking with Sam I'm passing this although I have raised MDL-28582

                      People

                      • Votes:
                        1 Vote for this issue
                        Watchers:
                        2 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          5/Dec/11