Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1.5, 2.2.2
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Themes
    • Labels:
      None
    • Database:
      Any
    • Testing Instructions:
      Hide
      1. Select Anomaly theme in usual way
      2. Go to any course that uses 'weekly format'
      3. Test that the 'current week' is highlighted 'Gray' at either end of the main content, but leaving the remainder, of the main content area, white.
      Show
      Select Anomaly theme in usual way Go to any course that uses 'weekly format' Test that the 'current week' is highlighted 'Gray' at either end of the main content, but leaving the remainder, of the main content area, white.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-23647_master
    • Rank:
      6195

      Description

      The week section contains 3 divs. The central one contains the activities. In most themes it fills the full height of its parent div. In the anomoly theme however there is a gap above it that somewhat spoils the look of the current week highlighting.

        Activity

        Hide
        Mary Evans added a comment -

        Initially I thought this had over time been fix. However the problem still persists. So a fix on its way.

        Show
        Mary Evans added a comment - Initially I thought this had over time been fix. However the problem still persists. So a fix on its way.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Thanks, this has been integrated now

        Show
        Dan Poltawski added a comment - Thanks, this has been integrated now
        Hide
        Mary Evans added a comment -

        ooops
        I forgot to re-base these

        Show
        Mary Evans added a comment - ooops I forgot to re-base these
        Hide
        Jason Fowler added a comment -

        looks good to me

        Show
        Jason Fowler added a comment - looks good to me
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This has been near becoming rejected, because it's not the best code you are able to produce.

        But, luckily, at the end, it has landed and has been spread to all repos out there.

        Many thanks and, don't forget it, keep improving your skills, you can!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: