Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23725

Feedback mod - email notification permissions not overridden

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.9.9
    • Fix Version/s: None
    • Component/s: Feedback
    • Labels:
      None
    • Environment:
      LAMP
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_19_STABLE

      Description

      Email notifications of feedback activity completion are still sent out even after permission is set to prevent/prohibit

      This occurs with roles in all contexts..

      Thanks,

      Andrea

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            grabs Andreas Grabs added a comment -

            Hi Andrea,
            sorry, can you a bit more clarify this?
            Is anybody getting an email or only teachers or admins?
            Happens this on all feedbacks in all courses or only in special courses?
            Do you use the last version of the feedback module?
            Andreas

            Show
            grabs Andreas Grabs added a comment - Hi Andrea, sorry, can you a bit more clarify this? Is anybody getting an email or only teachers or admins? Happens this on all feedbacks in all courses or only in special courses? Do you use the last version of the feedback module? Andreas
            Hide
            agordon Andrea Gregory (Gordon) added a comment -

            Hi Andreas,

            Thanks for your reply. In response to your questions....

            Teachers receiving email yes.... but they should not if permission is set to prevent them from receiving. The only way to stop the email is to change the setting in the Feedback activity... but that means no user role will receive... We only want to stop one role from receiving for example.

            Yes all courses.. no specifics..

            Yes, using the latest feedback module. Thank you!

            Andrea

            Show
            agordon Andrea Gregory (Gordon) added a comment - Hi Andreas, Thanks for your reply. In response to your questions.... Teachers receiving email yes.... but they should not if permission is set to prevent them from receiving. The only way to stop the email is to change the setting in the Feedback activity... but that means no user role will receive... We only want to stop one role from receiving for example. Yes all courses.. no specifics.. Yes, using the latest feedback module. Thank you! Andrea
            Hide
            grabs Andreas Grabs added a comment -

            Hi Andrea,

            I'm sorry but I can't reproduce this issue.
            The call what the feedback is doing to get the users who should receive an email is:
            ...
            return get_users_by_capability($context, 'mod/feedback:receivemail', '', 'lastname', '', '', $groups, '', false);
            ...
            It only returns users who has the needed capability.
            I think there must be a wrong role setting on your system.
            Please check the following:

            • Override permissions for the courses
            • Override permissions for all affected course categories
            • The general role definition.
              In addition check whether the teachers are member of a second role on that it is allowed to receive an email.
              Try prohibit instead prevent. Prohibit should dominate all other allow settings in lower contexts.

            good luck
            Andreas

            Show
            grabs Andreas Grabs added a comment - Hi Andrea, I'm sorry but I can't reproduce this issue. The call what the feedback is doing to get the users who should receive an email is: ... return get_users_by_capability($context, 'mod/feedback:receivemail', '', 'lastname', '', '', $groups, '', false); ... It only returns users who has the needed capability. I think there must be a wrong role setting on your system. Please check the following: Override permissions for the courses Override permissions for all affected course categories The general role definition. In addition check whether the teachers are member of a second role on that it is allowed to receive an email. Try prohibit instead prevent. Prohibit should dominate all other allow settings in lower contexts. good luck Andreas
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting this issue.

            We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

            If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

            Michael d;

            lqjjLKA0p6

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
            Hide
            salvetore Michael de Raadt added a comment -

            I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

            Show
            salvetore Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: