Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23773

In Binarius theme, layout popup shows the whole page on a dark grey background

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      ... which is unreadable.

      I am seeing this with a quiz in 'secure' mode.

        Gliffy Diagrams

          Activity

          Hide
          ptrkmkl Patrick Malley added a comment -

          John,

          I'm guessing that the page Tim is referring to isn't loading the wrappers that hold the white background. Can you have a look at this and let me know if this is a problem that should be fixed in all our new themes?

          Show
          ptrkmkl Patrick Malley added a comment - John, I'm guessing that the page Tim is referring to isn't loading the wrappers that hold the white background. Can you have a look at this and let me know if this is a problem that should be fixed in all our new themes?
          Hide
          timhunt Tim Hunt added a comment -

          Thanks Patrick and John for looking into this.

          Show
          timhunt Tim Hunt added a comment - Thanks Patrick and John for looking into this.
          Hide
          epsd John Stabinger added a comment -

          Tim,

          Can you give me a bit more info about where this is happening? Also, what browser you noticed it in?

          john

          Show
          epsd John Stabinger added a comment - Tim, Can you give me a bit more info about where this is happening? Also, what browser you noticed it in? john
          Hide
          timhunt Tim Hunt added a comment -

          Yes. I am sorry, I should have given better steps to reproduce:

          1. Log in as admin.
          2. Create a new course using the binarius theme.
          3. Enrol another user in this course as a student.
          4. Add a quiz.
          5. On the quiz settings page, under "Extra restrictions on attempts" set a password, and set Browser security to Full-screen pop-up. (And fill in the other required fields.)
          6. Go to 'Edit quiz' and add a question to the first page. (A true/false question is the quickest to create.)
          7. Now log out, and log in as a student.
          8. Go back to the quiz.
          9. Click start attempt.
          10. The page where you need to enter the password is broken.
          11. The page you get to after entering the password is fine.
          12. If you click 'End test...' then you get to another broken page.

          Show
          timhunt Tim Hunt added a comment - Yes. I am sorry, I should have given better steps to reproduce: 1. Log in as admin. 2. Create a new course using the binarius theme. 3. Enrol another user in this course as a student. 4. Add a quiz. 5. On the quiz settings page, under "Extra restrictions on attempts" set a password, and set Browser security to Full-screen pop-up. (And fill in the other required fields.) 6. Go to 'Edit quiz' and add a question to the first page. (A true/false question is the quickest to create.) 7. Now log out, and log in as a student. 8. Go back to the quiz. 9. Click start attempt. 10. The page where you need to enter the password is broken. 11. The page you get to after entering the password is fine. 12. If you click 'End test...' then you get to another broken page.
          Hide
          timhunt Tim Hunt added a comment -

          Sorry, I forgot to say. I am using Firefox.

          Show
          timhunt Tim Hunt added a comment - Sorry, I forgot to say. I am using Firefox.
          Hide
          epsd John Stabinger added a comment -

          This issue will appear in any theme that has a body background image. So, it would probably be easier to correct this by adding a white background color to the box(es) in the base or canvas theme.

          There is also a "That Functionality is currently disabled" pop-up message (or error) but again, it doesn't seem theme specific.

          Show
          epsd John Stabinger added a comment - This issue will appear in any theme that has a body background image. So, it would probably be easier to correct this by adding a white background color to the box(es) in the base or canvas theme. There is also a "That Functionality is currently disabled" pop-up message (or error) but again, it doesn't seem theme specific.
          Hide
          timhunt Tim Hunt added a comment -

          That Functionality is currently disabled is related to the bug I was working on when I found this problem.

          I think you are right, this needs to be in base or canvas. Sending it back to Patrick.

          Show
          timhunt Tim Hunt added a comment - That Functionality is currently disabled is related to the bug I was working on when I found this problem. I think you are right, this needs to be in base or canvas. Sending it back to Patrick.
          Hide
          ptrkmkl Patrick Malley added a comment -

          John,

          Could a possible solution here be to add a separate layout file to the Canvas theme for popups that adds an "inpopup" class. Then, we could add something like:

          body.inpopup

          {background:#fff !important;}

          to the Canvas stylesheet and be done with this ....

          It surprises me that such a class isn't already being added, actually.

          Show
          ptrkmkl Patrick Malley added a comment - John, Could a possible solution here be to add a separate layout file to the Canvas theme for popups that adds an "inpopup" class. Then, we could add something like: body.inpopup {background:#fff !important;} to the Canvas stylesheet and be done with this .... It surprises me that such a class isn't already being added, actually.
          Hide
          epsd John Stabinger added a comment -

          Added new file to canvas fixing popup background problem in some themes.

          Show
          epsd John Stabinger added a comment - Added new file to canvas fixing popup background problem in some themes.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10