Apu, can you please look at the code

Hi Marina,
just done a code review :

• !empty($content->id) ? (int) $content->id : null --> i'd take that out of file_prepare_draft_area() and into a separate variable for readability, see http://docs.moodle.org/dev/Coding_style#Wrapping_Control_Structures

• consider wrapping lines if they are too long (or go too far right) - again that's for readability.

looks good to me otherwise

cheers,
Aparup

Apu, I finally finished it. Sorry it took so long. If you think this should be backported feel free to cherry-pick to previous versions

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

err oops i was peer-reviewer - assigning to another integrator.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Attaching unrelated, but discovered while looking to this, error about the "Add Entry" template becoming somehow broken by the configlib.stuff, completely displacing labels and contents.

Crazy, crazy! Reproduced from 2.0 to 2.3.

Edited: non-initialised $patterns and $replacements arrays @ mod/data/edit.php (global scope) are the cause for this, with those vars being used by configlib stuff. I'll add one extra commit here if finally this lands.

Integrated, thanks! (21, 22 & master).

Note: I've added one extra commit to fix the global scope vars commented above.

Tested on master, 2.2 and 2.1. Works as described. Passing.

Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

icao_reverse('arreis olik rebemevon afla letoh ognat');

Closing, ciao