Moodle
  1. Moodle
  2. MDL-23858

Percentage is not calculating correctly when "Show totals excluding hidden items" is selected

    Details

    • Database:
      MySQL
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      We have a site having the following issues with the gradebook:

      We are looking to calculate categories and totals that contain hidden items. Our default is currently to hide totals that contain hidden items. When we select "Show totals excluding hidden items" we run into calculation errors.

      The attached image is a screen shot of a test student's grades from the student's view.

      In the second category titled, "Homework", we have five grade items. All worth 10 points each. The fifth item is hidden and students have no grades for the grade item. The student has accumulated 27 points so far out of 40. However, the category total is still displaying the range out of 50 and is calculating the 27 out of 50 to get a category percent of 54%. With the grade item hidden, the category should show the range out of 40 and the percentage 67.5% (27/40).

      In addition, once choosing "Show totals excluding hidden items" in the gradebook settings, the course total is now being weighted instead of being the sum of grades like it says in the Categories and items page. The course total should have a range of 0-340 and should add the 257 from the "Test" category and the 27 from the "Homework" category to get a total of 284. 284 points out of 340 equals a 83.5% course total. Instead it is taking the 85.67% earned in "Tests" category and the 54% earned in "Homework" category, adding them together to get 139.67 and then dividing by 2 to get 69.83%. This means that it is weighting each category evenly. However, it should not be weighting at all because sum of grades is selected.

      To conclude, when we selected "Show totals excluding hidden items", it is not excluding the hidden items from the totals and it is weighting categories instead of sum of grades.

        Gliffy Diagrams

          Issue Links

            Activity

            Kathryn Fortin created issue -
            Andrew Davis made changes -
            Field Original Value New Value
            Link This issue will be resolved by MDL-24330 [ MDL-24330 ]
            Martin Dougiamas made changes -
            Workflow jira [ 38220 ] MDL Workflow [ 46638 ]
            Martin Dougiamas made changes -
            Workflow MDL Workflow [ 46638 ] MDL Full Workflow [ 74887 ]
            Martin Soupcoff made changes -
            Attachment AggregateEmptyCellsOnly.png [ 24121 ]
            Michael Blake made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Priority Major [ 3 ] Blocker [ 1 ]
            Labels partner
            moodle.com made changes -
            Fix Version/s STABLE Sprint 11 [ 10751 ]
            Fix Version/s STABLE backlog [ 10463 ]
            Michael de Raadt made changes -
            Labels partner partner triaged
            Andrew Davis made changes -
            Status Open [ 1 ] Development in progress [ 3 ]
            moodle.com made changes -
            Fix Version/s STABLE Sprint 12 [ 10850 ]
            Fix Version/s STABLE Sprint 11 [ 10751 ]
            Andrew Davis made changes -
            Status Development in progress [ 3 ] Open [ 1 ]
            moodle.com made changes -
            Fix Version/s STABLE Sprint 13 [ 10952 ]
            Fix Version/s STABLE Sprint 12 [ 10850 ]
            moodle.com made changes -
            Fix Version/s STABLE Sprint 14 [ 11050 ]
            Fix Version/s STABLE Sprint 13 [ 10952 ]
            Chris Follin made changes -
            Labels partner triaged moodlerooms partner triaged
            Andrew Davis made changes -
            Link This issue will be resolved by MDL-11837 [ MDL-11837 ]
            Andrew Davis made changes -
            Fix Version/s DEV backlog [ 10464 ]
            Fix Version/s STABLE Sprint 14 [ 11050 ]
            Affects Version/s 2.0 [ 10122 ]
            Affects Version/s 1.9.9 [ 10405 ]
            Michael de Raadt made changes -
            Link This issue has been marked as being related by MDL-30142 [ MDL-30142 ]
            Andrew Davis made changes -
            Link This issue has a non-specific relationship to MDL-36239 [ MDL-36239 ]
            Andrew Davis made changes -
            Link This issue has a non-specific relationship to MDL-35984 [ MDL-35984 ]
            Andrew Davis made changes -
            Assignee Andrew Davis [ andyjdavis ]
            Michael de Raadt made changes -
            Fix Version/s BACKEND [ 12582 ]
            Martin Dougiamas made changes -
            Rank Ranked higher
            Martin Dougiamas made changes -
            Rank Ranked lower
            Martin Dougiamas made changes -
            Fix Version/s FRONTEND [ 12581 ]
            Fix Version/s BACKEND [ 12582 ]
            Martin Dougiamas made changes -
            Labels moodlerooms partner triaged moodlerooms netspot partner triaged
            Martin Dougiamas made changes -
            Rank Ranked higher
            Martin Dougiamas made changes -
            Rank Ranked lower
            Martin Dougiamas made changes -
            Rank Ranked lower
            Martin Dougiamas made changes -
            Epic Link MDL-44673 [ 74425 ]
            Charles Fulton made changes -
            Epic Link MDL-44673 [ 74425 ]
            Marina Glancy made changes -
            Labels moodlerooms netspot partner triaged moodlerooms netspot partner triage_in_progress
            Martin Dougiamas made changes -
            Rank Ranked higher
            Michael de Raadt made changes -
            Fix Version/s DEV backlog [ 10464 ]
            Fix Version/s FRONTEND [ 12581 ]
            Labels moodlerooms netspot partner triage_in_progress moodlerooms netspot partner triaged
            Michael de Raadt made changes -
            Status Open [ 1 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]

              People

              • Votes:
                12 Vote for this issue
                Watchers:
                14 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: