Moodle
  1. Moodle
  2. MDL-2387

Icon tooltips don't update when a language is changed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: None
    • Component/s: HTML Editor (TinyMCE)
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_15_STABLE
    • Rank:
      14141

      Description

      Janne, I know that you know about this bug, as the /lib/editor/lang/en.php now has extra cache control headers, but they still didn't fix this issue completely.

      I had a bit better results with the following cache header changes:

      header(Cache-control: max_age = $lifetime);

      header(Pragma: );

      to

      header(Cache-control: no-store,max_age=-1);

      header(Pragma: no-cache);

      Another, an overkill but catch-all solution would be, that in weblib.php change

      echo '<script type=text/javascript src='. $CFG->wwwroot .'/lib/editor/lang/en.php></script>'.\n;

      to

      echo '<script type=text/javascript src='. $CFG->wwwroot .'/lib/editor/lang/en.php?uniqid=' . uniqid('') . '></script>'.\n;

        Activity

        Hide
        Martin Dougiamas added a comment -

        From Janne Mikkonen (janne.mikkonen at julmajanne.com) Saturday, 15 January 2005, 12:22 AM:

        Yup!

        A lot has passed my evil eye and I've done nothing

        Hopefully I have some time in the near future to make all the changes that I've planned.

        From Janne Mikkonen (janne.mikkonen at julmajanne.com) Sunday, 16 January 2005, 02:53 AM:

        Fixed in main. Close the bug if the fix works :-D

        From Samuli Karevaara (samuli.karevaara at lamk.fi) Friday, 11 February 2005, 09:13 PM:

        Works in moodle 1.5 UNSTABLE DEVELOPMENT (2005020800)

        Show
        Martin Dougiamas added a comment - From Janne Mikkonen (janne.mikkonen at julmajanne.com) Saturday, 15 January 2005, 12:22 AM: Yup! A lot has passed my evil eye and I've done nothing Hopefully I have some time in the near future to make all the changes that I've planned. From Janne Mikkonen (janne.mikkonen at julmajanne.com) Sunday, 16 January 2005, 02:53 AM: Fixed in main. Close the bug if the fix works :-D From Samuli Karevaara (samuli.karevaara at lamk.fi) Friday, 11 February 2005, 09:13 PM: Works in moodle 1.5 UNSTABLE DEVELOPMENT (2005020800)
        Hide
        Michael Blake added a comment -

        assign to a valid user

        Show
        Michael Blake added a comment - assign to a valid user

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: