Details

    • Testing Instructions:
      Hide

      This test requires a Moodle site in which no cohorts have been created.

      1. Create a course and add self enrolment as an enrolment method, selecting 'Yes' to 'Allow self enrolments' and leaving all other settings as default. Check that there is no 'Only cohort members' setting.
      2. Create a cohortA and manually add student1 to it.
      3. Edit the self-enrolment method and select cohortA for 'Only cohort members'.
      4. Log in as student1 and make sure you can enrol in the course.
      5. Log in as a different student and check that the message 'Only members of cohortA can self-enrol' is displayed when you attempt to enrol.
      Show
      This test requires a Moodle site in which no cohorts have been created. Create a course and add self enrolment as an enrolment method, selecting 'Yes' to 'Allow self enrolments' and leaving all other settings as default. Check that there is no 'Only cohort members' setting. Create a cohortA and manually add student1 to it. Edit the self-enrolment method and select cohortA for 'Only cohort members'. Log in as student1 and make sure you can enrol in the course. Log in as a different student and check that the message 'Only members of cohortA can self-enrol' is displayed when you attempt to enrol.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w35_MDL-23875_m24_selfcohort
    • Rank:
      6249

      Description

      We would like to have a course that has self-enrollment enabled, but only for students who are in a certain cohort. I imagine this being accomplished as an option in the current self-enrollment plugin.

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          Thanks for the report.

          Show
          Petr Škoda added a comment - Thanks for the report.
          Hide
          Petr Škoda added a comment -

          Restore on different site does not reset the cohort setting, I am going to address it in MDL-35071.

          Show
          Petr Škoda added a comment - Restore on different site does not reset the cohort setting, I am going to address it in MDL-35071 .
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Man, we need better/detailed testing instructions. This is a candidate to QA test so we need special accurate testing-case.

          Show
          Eloy Lafuente (stronk7) added a comment - Man, we need better/detailed testing instructions. This is a candidate to QA test so we need special accurate testing-case.
          Hide
          Petr Škoda added a comment -

          Come on Eloy, what would you expect? A two page document describing how to set up self enrolment instance in a course and create new cohorts? What use does it have if I describe each click I did when testing it myself? Since when is developer responsible for setting up QA tests?

          Show
          Petr Škoda added a comment - Come on Eloy, what would you expect? A two page document describing how to set up self enrolment instance in a course and create new cohorts? What use does it have if I describe each click I did when testing it myself? Since when is developer responsible for setting up QA tests?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          These are your current instructions:

          1/ Add self enrol instance to some course - verify there is not cohort option before creating cohorts.
          2/ Add and edit some self-enrol instance, select some cohort.
          3/ Verify only members of cohorts can self-enrol.

          If you think they are correct and understandable, then for sure it's my fault. But I don't find them complete/easy enough to follow at all.

          I don't expect any 2-page document, although if you volunteer, it's welcome. 100%

          You are adding here one new functionality and you are in charge of, at least, describing it, so testers can test, qa-responsibles can create good qa-tests and people writing documentation can do it properly.

          Sorry. Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - These are your current instructions: 1/ Add self enrol instance to some course - verify there is not cohort option before creating cohorts. 2/ Add and edit some self-enrol instance, select some cohort. 3/ Verify only members of cohorts can self-enrol. If you think they are correct and understandable, then for sure it's my fault. But I don't find them complete/easy enough to follow at all. I don't expect any 2-page document, although if you volunteer, it's welcome. 100% You are adding here one new functionality and you are in charge of, at least, describing it, so testers can test, qa-responsibles can create good qa-tests and people writing documentation can do it properly. Sorry. Ciao
          Hide
          Petr Škoda added a comment -

          Sorry, this is about enabling self enrol in a course and enabling new cohort option + making sure only members of cohorts can self enrol. This should be tested by a person who already knows how to use self-enrol plugin, if you do not know how to set it up or what options there are at present you can not test it.

          Show
          Petr Škoda added a comment - Sorry, this is about enabling self enrol in a course and enabling new cohort option + making sure only members of cohorts can self enrol. This should be tested by a person who already knows how to use self-enrol plugin, if you do not know how to set it up or what options there are at present you can not test it.
          Hide
          Helen Foster added a comment -

          Just checking whether I understand how to use the self-enrol plugin by coming up with some testing instructions:

          This test requires a Moodle site in which no cohorts have been created.

          1. Create a course and add self enrolment as an enrolment method, selecting 'Yes' to 'Allow self enrolments' and leaving all other settings as default. Check that there is no 'Only cohort members' setting.
          2. Create a cohortA and manually add student1 to it.
          3. Edit the self-enrolment method and select cohortA for 'Only cohort members'.
          4. Log in as student1 and make sure you can enrol in the course.
          5. Log in as a different student and check that the message 'Only members of cohortA can self-enrol' is displayed when you attempt to enrol.

          Is it OK Petr? Does it cover everything sufficiently?

          PS Probably not relevant to this issue, but just noting that I didn't understand the 'Allow self enrolments' setting (default 'No') at all. What is the point in adding self enrolment as an enrolment method and selecting 'No' to 'Allow self enrolments'???

          Show
          Helen Foster added a comment - Just checking whether I understand how to use the self-enrol plugin by coming up with some testing instructions: This test requires a Moodle site in which no cohorts have been created. Create a course and add self enrolment as an enrolment method, selecting 'Yes' to 'Allow self enrolments' and leaving all other settings as default. Check that there is no 'Only cohort members' setting. Create a cohortA and manually add student1 to it. Edit the self-enrolment method and select cohortA for 'Only cohort members'. Log in as student1 and make sure you can enrol in the course. Log in as a different student and check that the message 'Only members of cohortA can self-enrol' is displayed when you attempt to enrol. Is it OK Petr? Does it cover everything sufficiently? PS Probably not relevant to this issue, but just noting that I didn't understand the 'Allow self enrolments' setting (default 'No') at all. What is the point in adding self enrolment as an enrolment method and selecting 'No' to 'Allow self enrolments'???
          Hide
          Helen Foster added a comment -

          Suggested cohortonly_help lang string improvement:

          'Self enrolment may be restricted to members of a specified cohort only. Note that changing this setting has no effect on existing enrolments.'

          Show
          Helen Foster added a comment - Suggested cohortonly_help lang string improvement: 'Self enrolment may be restricted to members of a specified cohort only. Note that changing this setting has no effect on existing enrolments.'
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Petr: no comments.

          Helen: much, much better. +1 to update current testing instructions with your alternative. Also, I'll be applying the help string change too. Thanks.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Petr: no comments. Helen: much, much better. +1 to update current testing instructions with your alternative. Also, I'll be applying the help string change too. Thanks. Ciao
          Hide
          Petr Škoda added a comment -

          Hi Helen, yes, that is part of what I did. Thanks a lot for the lang string fixes!

          It would be great if testers thought a bit and tried to find a way to break it, such as enable the "cohort only", test enrol, disable it, test enrol, enable with different cohort, test enrol, delete the cohort, test enrol, edit the self instance again, add more self instances to one course, it is also possible to change cohort view capability and see the list of available cohorts change, delete all cohorts, etc.

          Show
          Petr Škoda added a comment - Hi Helen, yes, that is part of what I did. Thanks a lot for the lang string fixes! It would be great if testers thought a bit and tried to find a way to break it, such as enable the "cohort only", test enrol, disable it, test enrol, enable with different cohort, test enrol, delete the cohort, test enrol, edit the self instance again, add more self instances to one course, it is also possible to change cohort view capability and see the list of available cohorts change, delete all cohorts, etc.
          Hide
          Petr Škoda added a comment -

          I have added extra commit with the improve help string, thanks a lot!

          Show
          Petr Škoda added a comment - I have added extra commit with the improve help string, thanks a lot!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks! (master only)

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (master only)
          Hide
          Frédéric Massart added a comment -

          Test passed. Thanks!

          Show
          Frédéric Massart added a comment - Test passed. Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I'm so proud...of you, many thanks!

          http://youtu.be/n64CdfDRnZY

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - I'm so proud...of you, many thanks! http://youtu.be/n64CdfDRnZY Closing as fixed, ciao
          Hide
          Mary Cooch added a comment -

          Removing docs_required label as this has been documented by Petr here and I added screenshots http://docs.moodle.org/24/en/Self_enrolment

          Show
          Mary Cooch added a comment - Removing docs_required label as this has been documented by Petr here and I added screenshots http://docs.moodle.org/24/en/Self_enrolment

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: