Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Backup
    • Labels:
      None
    • Database:
      MySQL
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The restore UI present a page with three sections.

      First section, "Choose an existing backup file", allows the selection of Section backups, Course backups and user backups. However, no such distinction is made when creating backups nor it is clear how to create three different backup types from the backup process. Restore link is very close to the backup file thus poorly visible.

      Second section, "Import a backup file" is misaligned. Uploading a backup file, no "Restore" link appears.

      Third section, Restore button is related to second, as only 1 backup is allowed to upload. This is an usability problem if I like to merge several course into one, since it is needed upload->restore->upload ->restore instead of upload all file then restore each one. Moreover, the restore should be a link instead of a button as it is the first section.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Sam Hemelryk added a comment -

            Hi Andrea,

            Martin was asking about this the other day, as such I have added Martin and Dongsheng to this issue as watchers and I see Eloy is here as well so lets discuss it.

            Dongsheng, could you please bring us up to speed with the three fileareas, what they are, why we use them (sorry I know we discussed it but for the life of me I can't rememebr).

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Hi Andrea, Martin was asking about this the other day, as such I have added Martin and Dongsheng to this issue as watchers and I see Eloy is here as well so lets discuss it. Dongsheng, could you please bring us up to speed with the three fileareas, what they are, why we use them (sorry I know we discussed it but for the life of me I can't rememebr). Cheers Sam
            Hide
            Dongsheng Cai added a comment -

            Hi all

            About three fileareas:

            course backup area will be used to store backup file when backup course using default settings:
            http://dongsheng.moodle.local/head/backup/backup.php?id=6

            section backup area is when you backup with section parameter, for example:
            http://dongsheng.moodle.local/head/backup/backup.php?id=6&section=47
            There is no clickable link for section backup yet.

            user backup area will be used if when 'Anonymize user information' checkbox is clicked in Initial settings

            Show
            Dongsheng Cai added a comment - Hi all About three fileareas: course backup area will be used to store backup file when backup course using default settings: http://dongsheng.moodle.local/head/backup/backup.php?id=6 section backup area is when you backup with section parameter, for example: http://dongsheng.moodle.local/head/backup/backup.php?id=6&section=47 There is no clickable link for section backup yet. user backup area will be used if when 'Anonymize user information' checkbox is clicked in Initial settings
            Hide
            Andrea Bicciolo added a comment -

            Thanks Dongsheng for the clarifications.

            Would be great to improve the user info then, currently users has only the trial and error way to understand that. A good improvement could be the selection of backup type on the Initial settings UI screen. As a second option, if it is preferred to keep interface as it is, would be good to show appropriate messages according to check box selections, so users get informed on what will happen to backups.

            What about second and third restore sections?

            Show
            Andrea Bicciolo added a comment - Thanks Dongsheng for the clarifications. Would be great to improve the user info then, currently users has only the trial and error way to understand that. A good improvement could be the selection of backup type on the Initial settings UI screen. As a second option, if it is preferred to keep interface as it is, would be good to show appropriate messages according to check box selections, so users get informed on what will happen to backups. What about second and third restore sections?
            Hide
            Sam Hemelryk added a comment -

            I've just linked a related issue created by Andrew some time ago with some suggestions abut this UI as well.

            Show
            Sam Hemelryk added a comment - I've just linked a related issue created by Andrew some time ago with some suggestions abut this UI as well.
            Hide
            Sam Hemelryk added a comment -

            All yours Dongsheng

            Show
            Sam Hemelryk added a comment - All yours Dongsheng
            Hide
            Martin Dougiamas added a comment - - edited

            Agreed about confusing interface.

            Some quick notes about the discussion we just had

            1) Remove the file tree completely.
            2) Move the import backup part from the bottom to the top, under heading 1
            3) Add two new headings under that, each with a table to show backups.

            • Backups from this course
            • My private backups

            4) The headings have help buttons with more about each one, explaining the users in backup etc
            5) The tables have sortable columns: backup name (no link), last modified, size and columns with an explicit restore link and download link.
            6) Under each table is a button to [Manage these files] which leads to a filemanager page to edit them in a draft area and save. No subdirectories allowed for now. People can even add/upload files there if they like.

            Show
            Martin Dougiamas added a comment - - edited Agreed about confusing interface. Some quick notes about the discussion we just had 1) Remove the file tree completely. 2) Move the import backup part from the bottom to the top, under heading 1 3) Add two new headings under that, each with a table to show backups. Backups from this course My private backups 4) The headings have help buttons with more about each one, explaining the users in backup etc 5) The tables have sortable columns: backup name (no link), last modified, size and columns with an explicit restore link and download link. 6) Under each table is a button to [Manage these files] which leads to a filemanager page to edit them in a draft area and save. No subdirectories allowed for now. People can even add/upload files there if they like.
            Hide
            Andrea Bicciolo added a comment -

            The Martin's suggested new interface is much better now. , thanks Sam for committing.

            Some more thoughts:

            1) Import a a backup file section
            A better alignment with the other sections would be possible ? It could be worth noticing in this section there is still a UI discrepancy among the restore link in the subsequent sections and the restore button in this section. The restore button is also always enabled and clicking it without uploading anything yields an error.

            Would it be possible to use the restore link as in the other sections (but dimmed) and enable it once the upload has been made?

            2)
            in the backup section I'm still unable to understand clearly how to create course backup for course backup area and for private backup area. I guess course backup are from backups while private backup are from Private files?

            3)
            (easy) the string "Choose an existing backup file from course bacup area" misses a k in the second backup word.

            4)
            clicking the button "Manage my backup files" in the "Choose an existing backup file from private backup areaChoose an existing backup file from private backup area" I supposed to be pointed to My private files. Is this correct? If it is, then breadcrumb are incorrect, path shown is MoodleHome->My profile settings

            Show
            Andrea Bicciolo added a comment - The Martin's suggested new interface is much better now. , thanks Sam for committing. Some more thoughts: 1) Import a a backup file section A better alignment with the other sections would be possible ? It could be worth noticing in this section there is still a UI discrepancy among the restore link in the subsequent sections and the restore button in this section. The restore button is also always enabled and clicking it without uploading anything yields an error. Would it be possible to use the restore link as in the other sections (but dimmed) and enable it once the upload has been made? 2) in the backup section I'm still unable to understand clearly how to create course backup for course backup area and for private backup area. I guess course backup are from backups while private backup are from Private files? 3) (easy) the string "Choose an existing backup file from course bacup area" misses a k in the second backup word. 4) clicking the button "Manage my backup files" in the "Choose an existing backup file from private backup areaChoose an existing backup file from private backup area" I supposed to be pointed to My private files. Is this correct? If it is, then breadcrumb are incorrect, path shown is MoodleHome->My profile settings
            Hide
            Dongsheng Cai added a comment -

            Hi Andrea

            1) I don't think that is possible, it is a standard moodle form, we cannot submit the form by click a link
            2) private backups are backup files when 'Anonymize user information' option is selected when you backup
            3) fixed by Sam, thank you very much http://cvs.moodle.org/moodle/lang/en/backup.php?r1=1.17&r2=1.18
            4) no, it is not your private files, it is a special area to store backup files only, but you are right, the breadcrumb is incorrect

            Show
            Dongsheng Cai added a comment - Hi Andrea 1) I don't think that is possible, it is a standard moodle form, we cannot submit the form by click a link 2) private backups are backup files when 'Anonymize user information' option is selected when you backup 3) fixed by Sam, thank you very much http://cvs.moodle.org/moodle/lang/en/backup.php?r1=1.17&r2=1.18 4) no, it is not your private files, it is a special area to store backup files only, but you are right, the breadcrumb is incorrect
            Hide
            Andrea Bicciolo added a comment -

            Hi Dongsheng,

            thank you for your comment, Ok for 2), however may we add something during the backup process informing users about where their backup will appear and why?

            Show
            Andrea Bicciolo added a comment - Hi Dongsheng, thank you for your comment, Ok for 2), however may we add something during the backup process informing users about where their backup will appear and why?
            Hide
            Dongsheng Cai added a comment - - edited

            Hi, Andrea

            Can you file another issue for backup about processing information? backup and restore are separate UIs.

            Show
            Dongsheng Cai added a comment - - edited Hi, Andrea Can you file another issue for backup about processing information? backup and restore are separate UIs.
            Show
            Andrea Bicciolo added a comment - http://tracker.moodle.org/browse/MDL-24539 Ciao!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: