Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23919

Database activity setting "Required entries" should belong to completion settings

    XMLWordPrintable

    Details

    • Database:
      MySQL
    • Testing Instructions:
      Hide
      1. In the test course ensure that Completion tracking is set to Yes in the course settings.
      2. Create a new instance of the Database activity with the following settings:
        1. Confirm that there is no Entries required field in the Entries section
        2. Under Activity completion section:
          1. Confirm that the Require entries field is disabled when Completion tracking is disabled, or set to manual
          2. Confirm that the Require entries field is enabled when Completion tracking is enabled and set to when conditions are met
        3. Set Completion tracking to Show activity as complete when conditions are met
        4. Confirm that the Count of entries input field is disabled when Require entries is unchecked
        5. Confirm that the Count of entries input field is enabled when Require entries is checked
        6. Check the Require entries checkbox
        7. Set the Count of entries to 2
      3. Click the "Save and Display" button.
      4. Create a new text input field:
        1. Set Field name to "YourName"
        2. Set Field Description to "Your name goes here"
        3. Click the add button
      5. Login as a student and navigate to the course
        1. Confirm that there is a completion checkbox next to the database and that it is unchecked
      6. Open the activity and add one entry
      7. Return back to the course view
        1. Confirm that the completion checkbox next to the database is still unchecked
      8. Add another entry
      9. Return back to the course view
        1. Confirm that the completion checkbox next to the database is now checked
      10. View the relevant row in the data DB table for this coursemodule
        1. Confirm that the requiredentries field is currently set to 0
        2. Update it and set it to 1
      11. Edit the activity once more and expand the Entries section
        1. Confirm that Entries required for completion (old) is visible
        2. Confirm that its' help is available and displays appropriate help
        3. Confirm that it has a banner beneath it advising of the deprecation
        4. Confirm that the current value matches the value you set in the DB
        5. Update it to None and save changes
      12. Edit the activity again and expand the Entries section again
        1. Confirm that the field, help, and banner have all gone
      13. Duplicate the activity
        1. Confirm that the Require entries field is ticked and Count of entries set to 2
      Show
      In the test course ensure that Completion tracking is set to Yes in the course settings. Create a new instance of the Database activity with the following settings: Confirm that there is no Entries required field in the Entries section Under Activity completion section: Confirm that the Require entries field is disabled when Completion tracking is disabled, or set to manual Confirm that the Require entries field is enabled when Completion tracking is enabled and set to when conditions are met Set Completion tracking to Show activity as complete when conditions are met Confirm that the Count of entries input field is disabled when Require entries is unchecked Confirm that the Count of entries input field is enabled when Require entries is checked Check the Require entries checkbox Set the Count of entries to 2 Click the "Save and Display" button. Create a new text input field: Set Field name to "YourName" Set Field Description to "Your name goes here" Click the add button Login as a student and navigate to the course Confirm that there is a completion checkbox next to the database and that it is unchecked Open the activity and add one entry Return back to the course view Confirm that the completion checkbox next to the database is still unchecked Add another entry Return back to the course view Confirm that the completion checkbox next to the database is now checked View the relevant row in the data DB table for this coursemodule Confirm that the requiredentries field is currently set to 0 Update it and set it to 1 Edit the activity once more and expand the Entries section Confirm that Entries required for completion (old) is visible Confirm that its' help is available and displays appropriate help Confirm that it has a banner beneath it advising of the deprecation Confirm that the current value matches the value you set in the DB Update it to None and save changes Edit the activity again and expand the Entries section again Confirm that the field, help, and banner have all gone Duplicate the activity Confirm that the Require entries field is ticked and Count of entries set to 2
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-23919-mod_data-required-entry-completion
    • Sprint:
      3.3 sprint 5

      Description

      Currently it belongs to General activity setting. It may be worth moving it to activity completion settings, otherwise it could be misleading for users, help says:

      "The number of entries a student is required to submit before the activity can be considered complete."

        Attachments

        1. db_new_completion_fields_help.png
          22 kB
          Marcus Green
        2. db_new_completion_fields.png
          16 kB
          Marcus Green
        3. db_old_completion_feedback.png
          21 kB
          Marcus Green
        4. db_old_completion_popup_help.png
          13 kB
          Marcus Green
        5. legacy_completion_helptext.png
          25 kB
          Marcus Green
        6. legacy_completion.png
          10 kB
          Marcus Green

          Issue Links

            Activity

              People

              Assignee:
              marcusgreen Marcus Green
              Reporter:
              andreabix Andrea Bicciolo
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              David Monllaó
              Tester:
              Andrew Nicols
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              11 Vote for this issue
              Watchers:
              21 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/May/17