Moodle
  1. Moodle
  2. MDL-24060

Need a way to control whether html_to_text lists all links in the HTML

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.1
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The html2text library we use has a $dolinks parameter to control whether it adds a list of URLs at the end of the plain-text output. However, the Moodle wrapper function html_to_text does not let you set that option. I am going to add an optional argument so you can control this.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Tim Hunt added a comment -

            It looks like I committed this. See commit dc3e95c0d8872be23bf1f8c3d24bed4bea03a9c6.

            However, I missed one useful unit test. Just about to issue a pull request for https://github.com/timhunt/moodle/compare/master...wip_MDL-24060

            Show
            Tim Hunt added a comment - It looks like I committed this. See commit dc3e95c0d8872be23bf1f8c3d24bed4bea03a9c6. However, I missed one useful unit test. Just about to issue a pull request for https://github.com/timhunt/moodle/compare/master...wip_MDL-24060
            Hide
            Tim Hunt added a comment -

            Pull request now checked in, so resolving this bug.

            Show
            Tim Hunt added a comment - Pull request now checked in, so resolving this bug.
            Hide
            Petr Skoda added a comment -

            thanks, closing

            Show
            Petr Skoda added a comment - thanks, closing

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: