Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23754 Performance improvements META
  3. MDL-24125

[Patch] Add in-memory cache of admin_category child objects

    XMLWordPrintable

    Details

    • Database:
      Any
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The attached patch improves performance by not having to recursively search the admin tree each time a child is added. As an admin user, admin_category->locate can easily be called over 3,000 times! In my tests, this improved load times of an admin user's page by about 7%.

        Attachments

          Issue Links

          duplicates

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-25429 Use static variables in functions to improve performance

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-26155 get_string calls are causing the generation of the admin tree to be be a painstaking performance hit

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              blt04 Brandon Turner
              Tester:
              Jérôme Mouneyrac
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Jake Dallimore, Jun Pataleta, Matteo Scaramuccia, Jake Dallimore, Jun Pataleta
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                21/Feb/11