Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-24173

Completion progress report needs horizontal scroll bar

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.1
    • Component/s: Activity completion
    • Labels:
      None
    • Environment:
      Moodle 2.0 Preview 4+ (Build: 20100911)
      Local install iMac/MAMP Safari.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Reports / ? Activity completion

      I have a large number of activities that I've set for completion. The table overflows to the right with no scroll bars showing. Only affects certain Themes, table does not resize to window.

        Gliffy Diagrams

          Activity

          Hide
          tsala Helen Foster added a comment -

          Vinny, thanks for your report. Please could you let us know which themes it affects.

          Show
          tsala Helen Foster added a comment - Vinny, thanks for your report. Please could you let us know which themes it affects.
          Hide
          vinnystocker Vinny Stocker added a comment -

          Hi,
          I'm using serenity. looks fine with the standard theme.

          Show
          vinnystocker Vinny Stocker added a comment - Hi, I'm using serenity. looks fine with the standard theme.
          Hide
          quen Sam Marshall added a comment -

          I think this is really a theme bug - themes should not cut off content, wide pages should always result in a scrollbar.

          If there is something that should be done in this report (a particular class to indicate to the theme that the page is expecting to be very wide) then let me know. However I think potentially most pages might in some cases be wider than there is space, so...

          Show
          quen Sam Marshall added a comment - I think this is really a theme bug - themes should not cut off content, wide pages should always result in a scrollbar. If there is something that should be done in this report (a particular class to indicate to the theme that the page is expecting to be very wide) then let me know. However I think potentially most pages might in some cases be wider than there is space, so...
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi guys,

          I've just attached a patch to this issue that sets the page layout to report for all course reports and fixes a couple of minor display glitches in the serenity theme. Could one of the watchers I've added please review these changes.

          In regards to the bug itself, wide content is still hard to deal with thanks to the floating divs layout, however we do now have the report layout which in most theme's allows the browser to scroll horizontally.
          However using the report layout isn't always the correct solution either, things like tables-for-layout should be converted to div structures and areas where people may attach horrendously large images should introduce there own resizing or overflow solution depending upon the layout of that page and what space there is to play with.

          Anyway hopefully this patch will get commit soon and you will once again be able to scroll horizontally on the completion progress report as well as the other course reports if required.

          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Hi guys, I've just attached a patch to this issue that sets the page layout to report for all course reports and fixes a couple of minor display glitches in the serenity theme. Could one of the watchers I've added please review these changes. In regards to the bug itself, wide content is still hard to deal with thanks to the floating divs layout, however we do now have the report layout which in most theme's allows the browser to scroll horizontally. However using the report layout isn't always the correct solution either, things like tables-for-layout should be converted to div structures and areas where people may attach horrendously large images should introduce there own resizing or overflow solution depending upon the layout of that page and what space there is to play with. Anyway hopefully this patch will get commit soon and you will once again be able to scroll horizontally on the completion progress report as well as the other course reports if required. Cheers Sam
          Hide
          skodak Petr Skoda added a comment -

          +1 makes sense

          Show
          skodak Petr Skoda added a comment - +1 makes sense
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks for the review Petr, has been commit now.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks for the review Petr, has been commit now.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Dec/10