Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.9
    • Fix Version/s: 1.9.11
    • Component/s: SCORM
    • Labels:
      None
    • Database:
      MySQL
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      1344

      Description

      In datamodels/scorm_13lib.php the cmi.core.exit value is tested to determine the status icon.
      In scorm 2004 we should use cmi.exit
      Patch attached

        Activity

        Hide
        valerian added a comment -

        If the learner attempt is ended and the status of the sco is "passed", but the sco did not fix the cmi.exit value to "normal" (it's the responsibility of the sco), then the "suspend icon" override the "passed icon" and the toc doesn't reflect the real status of the scoes.

        I think the "suspend icon" can only be added next to the status icon when the sco is incomplete.

        I've attached a patch for this,
        Valérian

        Show
        valerian added a comment - If the learner attempt is ended and the status of the sco is "passed", but the sco did not fix the cmi.exit value to "normal" (it's the responsibility of the sco), then the "suspend icon" override the "passed icon" and the toc doesn't reflect the real status of the scoes. I think the "suspend icon" can only be added next to the status icon when the sco is incomplete. I've attached a patch for this, Valérian
        Hide
        Dan Marsden added a comment -

        thanks Valerian - I've just pushed this into HEAD - could you please QA before I push into 1.9Stable?

        Show
        Dan Marsden added a comment - thanks Valerian - I've just pushed this into HEAD - could you please QA before I push into 1.9Stable?
        Hide
        valerian added a comment -

        Hi Dan,

        I've reviewed this, it's ok for me,
        I've noticed one difference with my patch : i add the suspend icon next to the status icon, but maybe you want to keep just one icon ?

        my version :
        $statusicon .= '<img src="'.$OUTPUT->pix_url('suspend', 'scorm').'" alt="'.$strsuspended.'" title="'.$strsuspended.'" />';

        your version :
        $statusicon = '<img src="'.$OUTPUT->pix_url('suspend', 'scorm').'" alt="'.$strstatus.' - '.$strsuspended.'" title="'.$strstatus.' - '.$strsuspended.'" />';

        Valérian

        Show
        valerian added a comment - Hi Dan, I've reviewed this, it's ok for me, I've noticed one difference with my patch : i add the suspend icon next to the status icon, but maybe you want to keep just one icon ? my version : $statusicon .= '<img src="'.$OUTPUT->pix_url('suspend', 'scorm').'" alt="'.$strsuspended.'" title="'.$strsuspended.'" />'; your version : $statusicon = '<img src="'.$OUTPUT->pix_url('suspend', 'scorm').'" alt="'.$strstatus.' - '.$strsuspended.'" title="'.$strstatus.' - '.$strsuspended.'" />'; Valérian
        Hide
        Dan Marsden added a comment -

        Hi Valerian,

        finally got round to looking at this again - I think I prefer to stick with the single icon - but I could probably be convinced to use 2 if a few more people voted on it and wanted it!

        otherwise - closing this off as fixed (now in 1.9stable and HEAD)

        thanks heaps!

        Show
        Dan Marsden added a comment - Hi Valerian, finally got round to looking at this again - I think I prefer to stick with the single icon - but I could probably be convinced to use 2 if a few more people voted on it and wanted it! otherwise - closing this off as fixed (now in 1.9stable and HEAD) thanks heaps!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: