Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-24241

Editing question with extra_question_fields doesn't load 0-values into controls [patch]

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.9, 2.0
    • Fix Version/s: None
    • Component/s: Questions
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      Simple, but hard to notice issue: we should have used isset() instead of empty(), since empty() doesn't work good on all values.

      Hope it doesn't take you too long to apply this - it is hindering preg question testing and development. The patch is absurdly easy...

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            ppichet Pierre Pichet added a comment -

            I Have done the CVS, I let you test and close everything

            Show
            ppichet Pierre Pichet added a comment - I Have done the CVS, I let you test and close everything
            Hide
            oa_sychev Oleg Sychev added a comment -

            Seems to work OK not only for me but for other people too. Fixed.
            Thanks to Pierre for the fast action...

            Show
            oa_sychev Oleg Sychev added a comment - Seems to work OK not only for me but for other people too. Fixed. Thanks to Pierre for the fast action...

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: