Moodle
  1. Moodle
  2. MDL-24255

Not using the proper editor element for manually grading questions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.1
    • Component/s: Questions
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. As teacher, go to a quiz with student attempts
      2. Review an attempt, and manually grade a response using the Make comment & override grade.
      3. Go to Results -> Manual grading in the navigtion, and manually grade using that.
      In both cases, verify the grade and comment are saved, and can be re-edited.

      Ideally verify this with the Use HTML editor option in your profile both on and off.

      Show
      1. As teacher, go to a quiz with student attempts 2. Review an attempt, and manually grade a response using the Make comment & override grade. 3. Go to Results -> Manual grading in the navigtion, and manually grade using that. In both cases, verify the grade and comment are saved, and can be re-edited. Ideally verify this with the Use HTML editor option in your profile both on and off.
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      917

      Description

      While playing with quizzes/questions to detect all the file_areas I have detected that the question_sessions->manualcomment is lacking support for files (and that's ok, as commented by Tim in HQ chat) but, at the same time, it seems that the question_sessions->manualcommentformat field isn't being handled at all.

      I get the html editor (without showing any "format"), then save the comment and, the manualcommentformat continues being 0 (FORMAT_MOODLE) should be 1 (FORMAT_HTML).

      So I guess something is missing there (mod/quiz/comment.php)

      Ciao

        Issue Links

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: