Moodle
  1. Moodle
  2. MDL-24262

selected users membership feature on group assign page unfinished

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Groups
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      24923

      Description

      if (selectCnt == 1 && userSummaries[selectIdx])

      { summaryDiv.innerHTML = userSummaries[selectIdx]; }

      else

      { summaryDiv.innerHTML = ''; }

      user summaries in group/clientlib.js not defined

      assigning to our JS specialist

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Hi Petr,

          I've just had a quick inspection of the code, userSummaries is being defined.... within an inline script tag as part of the group selector... EWWWW.
          It's probably a tad close to RC1 now to look at rewriting the JS in a OO fashion to which we can pass that information, however I will look to convert the inline script to use the proper page methods and comment the JS function appropriately, is there anything special you are aware of that we can include in the comments so you IDE knows it is a JS global? At a glance JSDoc has no equivalent to the @global tag in phpdoc.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Petr, I've just had a quick inspection of the code, userSummaries is being defined.... within an inline script tag as part of the group selector... EWWWW. It's probably a tad close to RC1 now to look at rewriting the JS in a OO fashion to which we can pass that information, however I will look to convert the inline script to use the proper page methods and comment the JS function appropriately, is there anything special you are aware of that we can include in the comments so you IDE knows it is a JS global? At a glance JSDoc has no equivalent to the @global tag in phpdoc. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Hi Petr,

          I've commit a patch now that tidies up the inline script.
          The variable itself is of course still global but I have created a tracker issue MDL-24262 that will look to conver the group selector (possibly user selectors as well if required) to YUI modules where we pass all requirements in.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Petr, I've commit a patch now that tidies up the inline script. The variable itself is of course still global but I have created a tracker issue MDL-24262 that will look to conver the group selector (possibly user selectors as well if required) to YUI modules where we pass all requirements in. Cheers Sam

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: