"save as new question" fails to store files

From Eloy http://tracker.moodle.org/browse/MDL-16094?focusedCommentId=92196&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_92196

Aha, found it!

It is the "save as new question" the one missing the @PLUGINFILE@ conversion !

To reproduce:

• create quiz
• add true/false question with images in question text, general feedback and true and false feedback (save it)
• edit the question and without changing anything, click on "save a new question"

Expected result:

• One new question is created with all the images using @PLUGINFILE@

Current (wrong) result:

• One error about URL not found happens (I commented that yesterday at MDL-16345).
• One new question is created but all the images are using "draftfiles" URLs (the conversion to @PLUGINFILE@ doesn't happen)

I guess the same will happen with other qtypes, I only tested the true/false one.

Ciao