Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-24298

"more" links on latest news block confusing for screen readers

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.9
    • Fix Version/s: 2.4
    • Component/s: Accessibility
    • Labels:
      None
    • Testing Instructions:
      Hide

      Add news block to a course with some recent news items
      Look at link - they should be linked from the item title instead of "more..."
      Click the links - they should take you to the news item.

      Show
      Add news block to a course with some recent news items Look at link - they should be linked from the item title instead of "more..." Click the links - they should take you to the news item.
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-24298-master

      Description

      The latest news block links to news stories with a link saying "more...". This is not helpful for screen reader users who need to be able to distinguish between links to different posts.

      This could be improved by making the post titles the links where a user has the "screen reader" option set in their profile.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            maherne Michael Aherne added a comment -

            Attached is a patch which makes this change.

            Show
            maherne Michael Aherne added a comment - Attached is a patch which makes this change.
            Hide
            gsisson Glenn Sisson added a comment -

            Hi Michael,

            I would like to achieve the same ie. use the post titles as links, but as standard without the screen reader option and remove the "more" link altogether. Could this be a setting in the block itself.? If not, what chnages do I need to make?

            Show
            gsisson Glenn Sisson added a comment - Hi Michael, I would like to achieve the same ie. use the post titles as links, but as standard without the screen reader option and remove the "more" link altogether. Could this be a setting in the block itself.? If not, what chnages do I need to make?
            Hide
            gsisson Glenn Sisson added a comment -

            Forgot to mention this was for Moodle 2.0 if it makes any difference.

            Show
            gsisson Glenn Sisson added a comment - Forgot to mention this was for Moodle 2.0 if it makes any difference.
            Hide
            mmorelos Martha added a comment -

            Are there any progress on this? this issue is still on 2.1 and probably on 2.2 :S

            Show
            mmorelos Martha added a comment - Are there any progress on this? this issue is still on 2.1 and probably on 2.2 :S
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Michael,

            Thanks for the patch.

            Unfortunately I don't think the approach is correct, we want to get rid of the screenreader flag in the future and always display decent, accessible info.

            So if your patch were changed to always display fuller, more meaninful information irrespective of the screenreader setting it'd be best.

            cheers!
            dan

            Show
            poltawski Dan Poltawski added a comment - Hi Michael, Thanks for the patch. Unfortunately I don't think the approach is correct, we want to get rid of the screenreader flag in the future and always display decent, accessible info. So if your patch were changed to always display fuller, more meaninful information irrespective of the screenreader setting it'd be best. cheers! dan
            Hide
            maherne Michael Aherne added a comment -

            Hi Dan,

            Thanks for the feedback! It's quite an old patch, so I'll get it updated and submit a proper pull request.

            Cheers

            Michael

            Show
            maherne Michael Aherne added a comment - Hi Dan, Thanks for the feedback! It's quite an old patch, so I'll get it updated and submit a proper pull request. Cheers Michael
            Hide
            maherne Michael Aherne added a comment -

            Updated patch to git.

            Show
            maherne Michael Aherne added a comment - Updated patch to git.
            Hide
            maherne Michael Aherne added a comment -

            Hi Dan, I've updated the patch to use the post title for the link regardless of the screenreader settings.

            Show
            maherne Michael Aherne added a comment - Hi Dan, I've updated the patch to use the post title for the link regardless of the screenreader settings.
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Michael,

            Its not necessary to increment the version number for this change (and makes merging between branches more difficult).

            Also please could you put the component in your commit message (news block) and also write testing instructions so we can test the change.

            Thanks!

            Show
            poltawski Dan Poltawski added a comment - Hi Michael, Its not necessary to increment the version number for this change (and makes merging between branches more difficult). Also please could you put the component in your commit message (news block) and also write testing instructions so we can test the change. Thanks!
            Hide
            maherne Michael Aherne added a comment -

            Thanks for the review, Dan! I'll get the patch sorted out and add some testing instructions.

            Show
            maherne Michael Aherne added a comment - Thanks for the review, Dan! I'll get the patch sorted out and add some testing instructions.
            Hide
            maherne Michael Aherne added a comment -

            Hi Dan, I've made the changes you suggested and rebased on top of the latest integration code.

            Cheers

            Michael

            Show
            maherne Michael Aherne added a comment - Hi Dan, I've made the changes you suggested and rebased on top of the latest integration code. Cheers Michael
            Hide
            poltawski Dan Poltawski added a comment -

            Great! Thanks Michael, submitting for integration.

            Show
            poltawski Dan Poltawski added a comment - Great! Thanks Michael, submitting for integration.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Michael, a nice simple improvement and has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Michael, a nice simple improvement and has been integrated now
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested and works fine.
            Latest news topics are now linked through the title rather than a 'more' link.

            Show
            abgreeve Adrian Greeve added a comment - Tested and works fine. Latest news topics are now linked through the title rather than a 'more' link.
            Hide
            nebgor Aparup Banerjee added a comment -

            yay, it works!

            This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

            Thank you all for taking the time to get us here.

            cheers!

            Show
            nebgor Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12