Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-24343

Properly deprecate unzip_file/zip_file

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.8.1, 3.2
    • Fix Version/s: 3.2
    • Component/s: General
    • Testing Instructions:
      Hide

      Unit tests cover much of this change and have done for some time.

      Testing zip

      The zip functionality was only used in one place - lib/odslib.php.
      This can be easily tested as follows:

      1. Navigate to lib/tests/other/spreadsheettestpage.php on your site
      2. Press the Test ODS Format button and download the file
      3. Open in your ODS reader of choice
        1. Confirm that it works
      Unzip functionality

      The unzip_file function was used in two locations:

      1. The plugin installer; and
      2. The WebCT question importer
      plugin installer
      1. Install some plugins from zip
        1. Confirm lack of errors and plugins successfully installed
      WebCT question importer
      1. Open a course and navigate to the question bank
      2. Select Import from the navtree
      3. Upload the attached WebCT zip file and complete the upload
        1. Confirm that 2 questions were imported
        2. Open the Short Answer question and confirm that the image shows
      Show
      Unit tests cover much of this change and have done for some time. Testing zip The zip functionality was only used in one place - lib/odslib.php . This can be easily tested as follows: Navigate to lib/tests/other/spreadsheettestpage.php on your site Press the Test ODS Format button and download the file Open in your ODS reader of choice Confirm that it works Unzip functionality The unzip_file function was used in two locations: The plugin installer; and The WebCT question importer plugin installer Install some plugins from zip Confirm lack of errors and plugins successfully installed WebCT question importer Open a course and navigate to the question bank Select Import from the navtree Upload the attached WebCT zip file and complete the upload Confirm that 2 questions were imported Open the Short Answer question and confirm that the image shows
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_28_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-24343-master
    • Story Points:
      3
    • Sprint:
      3.2 Sprint 3

      Description

      Sam - Related to your recent commit for MDL-19786, I did a grep of 2.0 code base and found a couple more instances of where the deprecated unzip_file/zip_file is being used:

      /question/format/blackboard_six/format.php
      /lib/componentlib.php

      Peace - Anthony

      p.s. - Perhaps we should create a meta issue to grep for deprecated functions as part of code clean up

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16