Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-24356

auth/db should use new style of building SQL queries

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      In particular... it builds an IN clause of usernames with implode(). I'm attaching a patch that makes it use DB->get_in_or_equal() instead with proper placeholders and params.

        Attachments

          Activity

            People

            Assignee:
            skodak Petr Skoda
            Reporter:
            jk3us Jay Knight
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              24/Nov/10