Moodle
  1. Moodle
  2. MDL-24380

Chat: autoscroll help popup incorrect and doesn't display fully (it only concerns the alternative chat methods)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.5
    • Fix Version/s: 2.4.7, 2.5.3, 2.6, FRONTEND
    • Component/s: Chat
    • Labels:
    • Story Points:
      3
    • Rank:
      53363
    • Sprint:
      FRONTEND Sprint 6

      Description

      Autoscroll help popup gives info on using chat, rather than the autoscroll feature.

        Issue Links

          Activity

          Hide
          Helen Foster added a comment -

          I don't think the autoscroll checkbox needs a popup at all. Dongsheng please could you remove it.

          Show
          Helen Foster added a comment - I don't think the autoscroll checkbox needs a popup at all. Dongsheng please could you remove it.
          Hide
          Helen Foster added a comment -

          In addition to giving the wrong information, the help popup can't even be read - see screenshot (using Firefox on Ubuntu).

          Show
          Helen Foster added a comment - In addition to giving the wrong information, the help popup can't even be read - see screenshot (using Firefox on Ubuntu).
          Hide
          Yvonne Hamilton added a comment -

          I agree that the help popup is not properly visible at the bottom of the page which looks bad to end users. It would be Ok if it could centre on the page...is that an option?

          Show
          Yvonne Hamilton added a comment - I agree that the help popup is not properly visible at the bottom of the page which looks bad to end users. It would be Ok if it could centre on the page...is that an option?
          Hide
          Dongsheng Cai added a comment -

          This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.
          For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          Show
          Dongsheng Cai added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
          Hide
          Helen Foster added a comment -

          This issue remains a problem in Moodle 2.5.

          Show
          Helen Foster added a comment - This issue remains a problem in Moodle 2.5.
          Hide
          Jérôme Mouneyrac added a comment - - edited

          I remove it as suggested by Helen. Note that this help is not used by the default version of the chat (how many people knows that there are other version that AJAX/accessible?), so imo I don't think people need this chat help anyway. As an alterntive we could display a link to the Moodle doc but I wonder the interest to have 6 chats (3 methods x JS/Accessible).

          Show
          Jérôme Mouneyrac added a comment - - edited I remove it as suggested by Helen. Note that this help is not used by the default version of the chat (how many people knows that there are other version that AJAX/accessible?), so imo I don't think people need this chat help anyway. As an alterntive we could display a link to the Moodle doc but I wonder the interest to have 6 chats (3 methods x JS/Accessible).
          Hide
          Andrew Davis added a comment - - edited

          A nice simple change.

            • Smilies - Any smiley faces (emoticons) that you can type elsewhere in Moodle can also be typed here, for example
            • Links - Website addresses will be turned into links automatically
            • Emoting - You can start a line with "/me" or ":" to emote, for example if your name is Kim and you type ":laughs!" or "/me laughs!" then everyone will see "Kim laughs!"
            • Beeps - You can send a sound to other participants by clicking the "beep" link next to their name. A useful shortcut to beep all the people in the chat at once is to type "beep all".
            • HTML - If you know some HTML code, you can use it in your text to do things like insert images, play sounds or create different coloured text';

          Is this information available anywhere else? Even if it is just in docs, this should be available to users somewhere so that we are not losing information.

          I made a few minor corrections to the testing instructions. Submit for integration when you are ready.

          Show
          Andrew Davis added a comment - - edited A nice simple change. Smilies - Any smiley faces (emoticons) that you can type elsewhere in Moodle can also be typed here, for example Links - Website addresses will be turned into links automatically Emoting - You can start a line with "/me" or ":" to emote, for example if your name is Kim and you type ":laughs!" or "/me laughs!" then everyone will see "Kim laughs!" Beeps - You can send a sound to other participants by clicking the "beep" link next to their name. A useful shortcut to beep all the people in the chat at once is to type "beep all". HTML - If you know some HTML code, you can use it in your text to do things like insert images, play sounds or create different coloured text'; Is this information available anywhere else? Even if it is just in docs, this should be available to users somewhere so that we are not losing information. I made a few minor corrections to the testing instructions. Submit for integration when you are ready.
          Hide
          Jérôme Mouneyrac added a comment - - edited

          Thanks Andrew for reviewing and editing the testing instructions. The information is in the Moodledocs: http://docs.moodle.org/24/en/Using_Chat.

          Also see: https://tracker.moodle.org/browse/MDL-42420

          Show
          Jérôme Mouneyrac added a comment - - edited Thanks Andrew for reviewing and editing the testing instructions. The information is in the Moodledocs: http://docs.moodle.org/24/en/Using_Chat . Also see: https://tracker.moodle.org/browse/MDL-42420
          Hide
          Helen Foster added a comment -

          You're right Andrew - the info on what you can type in the chat should be available in Moodle, and not just in the docs. I don't think we need a help popup for the autoscroll feature, but we definitely need a 'Using chat' help popup - in all versions of the chat.

          Show
          Helen Foster added a comment - You're right Andrew - the info on what you can type in the chat should be available in Moodle, and not just in the docs. I don't think we need a help popup for the autoscroll feature, but we definitely need a 'Using chat' help popup - in all versions of the chat.
          Hide
          Jérôme Mouneyrac added a comment - - edited

          It's technically more complex that few minutes as some of the chat UIs are using iframes. Also looking at the chat code it's going to take even more resource on code reviews. There are no problems on the default chat, so I advice we integrate my patch for this report and study how to do a great chat in MDL-42420 when we are out of code freeze.

          Show
          Jérôme Mouneyrac added a comment - - edited It's technically more complex that few minutes as some of the chat UIs are using iframes. Also looking at the chat code it's going to take even more resource on code reviews. There are no problems on the default chat, so I advice we integrate my patch for this report and study how to do a great chat in MDL-42420 when we are out of code freeze.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Helen Foster added a comment -

          Jerome, thanks for your comment. I appreciate that adding the 'Using chat' help back into all versions of the chat is outside the scope of this issue, and so have created MDL-42434 for it.

          Thus in this issue we can focus only on removing the help popup which appeared next to the autoscroll.

          Show
          Helen Foster added a comment - Jerome, thanks for your comment. I appreciate that adding the 'Using chat' help back into all versions of the chat is outside the scope of this issue, and so have created MDL-42434 for it. Thus in this issue we can focus only on removing the help popup which appeared next to the autoscroll.
          Hide
          Marina Glancy added a comment - - edited

          Hi guys, this help icon looks terrible! How about we remove it from 2.4 and 2.5 as well but without removing the help string in case anybody uses it somewhere else.

          (removing the string in 2.6 is ok)

          Show
          Marina Glancy added a comment - - edited Hi guys, this help icon looks terrible! How about we remove it from 2.4 and 2.5 as well but without removing the help string in case anybody uses it somewhere else. (removing the string in 2.6 is ok)
          Hide
          Jérôme Mouneyrac added a comment -

          Yes Marina I can do that, I'll add 2.4/2.5 branches.

          Show
          Jérôme Mouneyrac added a comment - Yes Marina I can do that, I'll add 2.4/2.5 branches.
          Hide
          Jérôme Mouneyrac added a comment - - edited

          Done Marina

          Show
          Jérôme Mouneyrac added a comment - - edited Done Marina
          Hide
          Marina Glancy added a comment -

          Thanks Jerome, integrated in 2.4, 2.5 and 2.6

          Show
          Marina Glancy added a comment - Thanks Jerome, integrated in 2.4, 2.5 and 2.6
          Hide
          Mark Nelson added a comment -

          Thanks Jerome, works as expected. I did find an issue while testing this and created MDL-42465.

          Show
          Mark Nelson added a comment - Thanks Jerome, works as expected. I did find an issue while testing this and created MDL-42465 .
          Hide
          Helen Foster added a comment -

          Please can the help string NOT be removed in 2.6, since as Andrew says, the info on what you can type in the chat should be available in Moodle, and I have created MDL-42434 for it. If the help string is removed and then re-added, it causes unnecessary extra work for our translators.

          Show
          Helen Foster added a comment - Please can the help string NOT be removed in 2.6, since as Andrew says, the info on what you can type in the chat should be available in Moodle, and I have created MDL-42434 for it. If the help string is removed and then re-added, it causes unnecessary extra work for our translators.
          Hide
          Marina Glancy added a comment -

          ok, we are trying to revert this commit so AMOS does not delete string. Thanks for telling Helen

          Show
          Marina Glancy added a comment - ok, we are trying to revert this commit so AMOS does not delete string. Thanks for telling Helen
          Hide
          Eloy Lafuente (stronk7) added a comment -

          "Aequam memento rebus in arduis servare mentem"

          Many thanks for your hard work, this is now part of "Moodle, the LMS". Closing!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - "Aequam memento rebus in arduis servare mentem" Many thanks for your hard work, this is now part of "Moodle, the LMS". Closing! Ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile