Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.9.9, 2.0, 2.1.4, 2.2.1
-
Component/s: Questions
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
Things have changed since this problem was originally reported, but the situation now is:
1. You should be able to enter match answers that work with the multilang filter, but no other HTML. That is, the answers are PARAM_TEXT. This is currently working.
2. Questions with multilang syntax in the answers should work. That was broken.
Original description:
The in_array() check in line 246 (1.9) / 264 (2.0) of questiontype.php doesn't align with what's added to the array in the next line. I think it's probably fairly rare that people have tags in this field, but it leads to unexpected behavior with some answers added twice or not being treated as equal. I can get the same answer three times in the drop-down menu along with the expected unpredictable grading if I add the following answers (tested with the most recent 2.0):
<b>a</b>
<i>a</i>
a
Gliffy Diagrams
Attachments
Issue Links
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
I pretty sure that $allanswers should have the formatted text because I think it's used to align duplicates between the response and the just-generated reduced set, which might not have chosen the same id to represent a particular duplicate. I think that's what's going on, anyway. They will both refer to the formatted text displayed in the drop-down.
It turns out that the same formatting needs to be taken into account in the grading, too. I'll attach a patch which works in my simple tests. There might be something I've overlooked.
Or perhaps it would be better/simpler to strip tags and format when it's saved in the database? Maybe it could be part of the form validation that won't let you save unless $ans == strip_tags($ans)?
Generally, we sanitise text on output. I think the logic is that cleaning up HTML (or converting it to plain text) is a complex operation, so the algorithms are likely to improve over time. Will try to review your patch soon, but probably not this week.
I need to look at this, see if it still affects 2.1+, and if so, apply the fix.
The correct fix is to call format_string on the choices. Submitting for integration.
Thanks Tim this has been integrated now.
Note this has been detected to cause unittests to fail under 21/22/master with information:
Failed
|
|
|
qtype_match_walkthrough_test.test_match_with_tricky_html_choices (from _question_type_match_simpletest_testwalkthrough.php)
|
|
|
Failing for the past 16 builds (Since #107 )
|
Took 25 ms.
|
Error Message
|
|
|
Content [<div id="q1" class="que match deferredfeedback notyetanswered"><div class="info"><div class="state">Not yet answered</div><div class="grade">Marked out of 3.00</div><div class="questionflag"><img src="http://localhost/theme/image.php?theme=standard&image=i%2Funflagged&rev=281" alt="Not flagged" /></div>
|
</div><div class="content"><div class="formulation"><h3 class="accesshide">Question text</h3><input type="hidden" name="q0u6n8KZ655:1_:sequencecheck" value="1" /><div class="qtext">Classify the animals.</div><div class="ablock"><table class="answer"><tbody><tr class="r0"><td class="text">(1, 2]</td><td class="control"><select id="menuq0u6n8KZ655:1_sub0" class="select menuq0u6n8KZ655:1_sub0" name="q0u6n8KZ655:1_sub0"><option selected="selected" value="0">Choose...</option><option value="1">1 ≤ x ≤ 2</option><option value="2">1 < x ≤ 2</option><option value="3">1 ≤ x < 2</option></select> </td></tr><tr class="r1"><td class="text">[1, 2]</td><td class="control"><select id="menuq0u6n8KZ655:1_sub1" class="select menuq0u6n8KZ655:1_sub1" name="q0u6n8KZ655:1_sub1"><option selected="selected" value="0">Choose...</option><option value="1">1 ≤ x ≤ 2</option><option value="2">1 < x ≤ 2</option><option value="3">1 ≤ x < 2</option></select> </td></tr><tr class="r0"><td class="text">[1, 2)</td><td class="control"><select id="menuq0u6n8KZ655:1_sub2" class="select menuq0u6n8KZ655:1_sub2" name="q0u6n8KZ655:1_sub2"><option selected="selected" value="0">Choose...</option><option value="1">1 ≤ x ≤ 2</option><option value="2">1 < x ≤ 2</option><option value="3">1 ≤ x < 2</option></select> </td></tr></tbody></table></div></div></div></div>] does not contain an enabled <select> with name q0u6n8KZ655:1_sub0 and choices Choose..., 1 ≤ x ≤ 2, 1 < x ≤ 2, 1 ≤ x < 2 at [/question/engine/simpletest/helpers.php line 511]
|
Ciao 
I think I have fixed it, but Petr disagrees.
MDL-31101 has been integrated and tests (both issue ones and CI ones) are passing, so I'm sending this to own-testing again. Thanks!
Works Great
Thanks for fixing this, Tim.
This virus has been spread upstream, everybody will be infected soon. Congrats, you did it!
Closing, ciao
Yes, you are right. Thanks for spotting this.
I cannot immediately work out the correct fix, because I cannot immediately work out what should go into the $allanswers array - should that be the version with tags stripped, or not.
Is there any chance you coudl work out the fix, then I can review it and commit it? Don't worry if you are as busy as I am. Thanks.