Moodle
  1. Moodle
  2. MDL-24401

2.0 Lesson, string default changes needed

    Details

    • Testing Instructions:
      Hide
      1. create new lesson
      2. select 'content page', on content page form scroll down and make sure the button is now labeled with 'save'
      3. add question page, after selecting question type, make sure the button is labeled as 'add a question page'
      4. add the question page, at the bottom of question form, make sure the button is labeled as 'save'
      Show
      create new lesson select 'content page', on content page form scroll down and make sure the button is now labeled with 'save' add question page, after selecting question type, make sure the button is labeled as 'add a question page' add the question page, at the bottom of question form, make sure the button is labeled as 'save'
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      894

      Description

      Short version: see post http://moodle.org/mod/forum/discuss.php?d=164368#p721630

      Quick fix:

      change addaquestionpage to read "Add the page"
      change activitylinkname to "{$a}"
      change returnto to "Go to: "

      I think we can put off renaming the addaquestionpage as a $string to something else, just change the default.

      Has to be an error in the lesson php code where it puts the $returnto in front of the $activitylinkedto when there is a linked to activity in Lesson settings. Not sure which file but assume view.php. Here is the screen shot I put in the forum. Of course I put "Wowie I want to go to:" to make sure I had the right string

      Deleted my recreation of the add a content page where it says "add a question page". Changing the default string text seemed elegant and simple. It does not matter that the teacher know it is a question or content or end of branch page for that matter.

      1. patch.patch
        2 kB
        sachintha rajith
      1. Lesson end of page links.png
        22 kB

        Issue Links

          Activity

          Hide
          Bente Olsen added a comment -

          I agree with Chris that the button text could very well be simplified. I even think that there is no need to have different text for an edited and a created page, "Save" covers the function.

          Show
          Bente Olsen added a comment - I agree with Chris that the button text could very well be simplified. I even think that there is no need to have different text for an edited and a created page, "Save" covers the function.
          Hide
          Chris Collman added a comment -

          Added 2 more strings to the list.

          Show
          Chris Collman added a comment - Added 2 more strings to the list.
          Hide
          Michael de Raadt added a comment -

          It looks like this has been duplicated a number of times now, so I'm bumping this issue's priority.

          Show
          Michael de Raadt added a comment - It looks like this has been duplicated a number of times now, so I'm bumping this issue's priority.
          Hide
          sachintha rajith added a comment -

          Hi,
          I have submitted a patch for the button renaming issue. I agreed with quick fixing. It is simple. But my patch provide button names according to the context which I think more usable in the context of HCI aspects. Try it. If it solves give your feedbacks.
          Thanks!

          Show
          sachintha rajith added a comment - Hi, I have submitted a patch for the button renaming issue. I agreed with quick fixing. It is simple. But my patch provide button names according to the context which I think more usable in the context of HCI aspects. Try it. If it solves give your feedbacks. Thanks!
          Hide
          Michael de Raadt added a comment -

          This issue has now be duplicated five times. I'm bumping this issue as it is clearly annoying a lot of users.

          Show
          Michael de Raadt added a comment - This issue has now be duplicated five times. I'm bumping this issue as it is clearly annoying a lot of users.
          Hide
          Rossiani Wijaya added a comment -

          Hi All,

          The string for activity link has been fixed through MDL-27922.

          Thank you for the patch Sachintha, however a better way to fix this is through the definition(). Please take a look the patch.

          Show
          Rossiani Wijaya added a comment - Hi All, The string for activity link has been fixed through MDL-27922 . Thank you for the patch Sachintha, however a better way to fix this is through the definition(). Please take a look the patch.
          Hide
          Ankit Agarwal added a comment -

          Hi Rosie,
          This looks great.
          +1 for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Rosie, This looks great. +1 for integration. Thanks
          Hide
          Ankit Agarwal added a comment -

          sorry forgot to finsh the review.
          thanks

          Show
          Ankit Agarwal added a comment - sorry forgot to finsh the review. thanks
          Hide
          Rossiani Wijaya added a comment -

          Thanks Ankit.

          Submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Thanks Ankit. Submitting for integration review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Thanks Rosie, thats been integrated now

          Show
          Dan Poltawski added a comment - Thanks Rosie, thats been integrated now
          Hide
          Frédéric Massart added a comment -

          Success on 2.1, 2.2 and master

          Show
          Frédéric Massart added a comment - Success on 2.1, 2.2 and master
          Hide
          Eloy Lafuente (stronk7) added a comment -

          U P S T R E A M I Z E D !

          Many thanks for the hard work, closing this as fixed.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: